Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: tools/clang/blink_gc_plugin/tests/traceimpl_overloaded_error.h

Issue 2655933002: blink_gc_plugin: retire overloaded traceImpl detection and handling. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/traceimpl_overloaded_error.h
diff --git a/tools/clang/blink_gc_plugin/tests/traceimpl_overloaded_error.h b/tools/clang/blink_gc_plugin/tests/traceimpl_overloaded_error.h
index be587dec71465095e7e7b6717a1429d6b3ef1f93..611b076b78071a166003f16e59e735ed6ecfe5c8 100644
--- a/tools/clang/blink_gc_plugin/tests/traceimpl_overloaded_error.h
+++ b/tools/clang/blink_gc_plugin/tests/traceimpl_overloaded_error.h
@@ -12,62 +12,41 @@ namespace blink {
class X : public GarbageCollected<X> {
public:
void Trace(Visitor*) {}
- void Trace(InlinedGlobalMarkingVisitor) {}
};
class InlinedBase : public GarbageCollected<InlinedBase> {
public:
- virtual void Trace(Visitor* visitor) { TraceImpl(visitor); }
- virtual void Trace(InlinedGlobalMarkingVisitor visitor) {
- TraceImpl(visitor);
- }
-
- private:
- template <typename VisitorDispatcher>
- void TraceImpl(VisitorDispatcher visitor) {
+ virtual void Trace(Visitor* visitor) {
// Missing visitor->Trace(x_base_).
}
+ private:
Member<X> x_base_;
};
class InlinedDerived : public InlinedBase {
public:
- void Trace(Visitor* visitor) override { TraceImpl(visitor); }
- void Trace(InlinedGlobalMarkingVisitor visitor) override {
- TraceImpl(visitor);
- }
-
- private:
- template <typename VisitorDispatcher>
- void TraceImpl(VisitorDispatcher visitor) {
+ void Trace(Visitor* visitor) override {
// Missing visitor->Trace(x_derived_) and InlinedBase::Trace(visitor).
}
+ private:
Member<X> x_derived_;
};
class ExternBase : public GarbageCollected<ExternBase> {
public:
virtual void Trace(Visitor*);
- virtual void Trace(InlinedGlobalMarkingVisitor);
private:
- template <typename VisitorDispatcher>
- void TraceImpl(VisitorDispatcher);
-
Member<X> x_base_;
};
class ExternDerived : public ExternBase {
public:
void Trace(Visitor*) override;
- void Trace(InlinedGlobalMarkingVisitor) override;
private:
- template <typename VisitorDispatcher>
- void TraceImpl(VisitorDispatcher);
-
Member<X> x_derived_;
};

Powered by Google App Engine
This is Rietveld 408576698