Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: tools/clang/blink_gc_plugin/tests/legacy_naming/trace_after_dispatch_impl_error.cpp

Issue 2655933002: blink_gc_plugin: retire overloaded traceImpl detection and handling. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/legacy_naming/trace_after_dispatch_impl_error.cpp
diff --git a/tools/clang/blink_gc_plugin/tests/legacy_naming/trace_after_dispatch_impl_error.cpp b/tools/clang/blink_gc_plugin/tests/legacy_naming/trace_after_dispatch_impl_error.cpp
index 23798f70275c3f4e6911146b80ed33be4ccfc5d9..9157bc0dacce28020c6874ccdd2ebb3d016ac073 100644
--- a/tools/clang/blink_gc_plugin/tests/legacy_naming/trace_after_dispatch_impl_error.cpp
+++ b/tools/clang/blink_gc_plugin/tests/legacy_naming/trace_after_dispatch_impl_error.cpp
@@ -6,9 +6,7 @@
namespace blink {
-template <typename VisitorDispatcher>
-inline void TraceAfterDispatchInlinedBase::traceImpl(
- VisitorDispatcher visitor) {
+inline void TraceAfterDispatchInlinedBase::trace(Visitor* visitor) {
// Implement a simple form of manual dispatching, because BlinkGCPlugin
// checks if the tracing is dispatched to all derived classes.
//
@@ -24,15 +22,6 @@ inline void TraceAfterDispatchInlinedBase::traceImpl(
}
void TraceAfterDispatchExternBase::trace(Visitor* visitor) {
- traceImpl(visitor);
-}
-
-void TraceAfterDispatchExternBase::trace(InlinedGlobalMarkingVisitor visitor) {
- traceImpl(visitor);
-}
-
-template <typename VisitorDispatcher>
-inline void TraceAfterDispatchExternBase::traceImpl(VisitorDispatcher visitor) {
if (tag_ == DERIVED) {
// Missing dispatch call:
// static_cast<TraceAfterDispatchExternDerived*>(this)->traceAfterDispatch(
@@ -43,32 +32,10 @@ inline void TraceAfterDispatchExternBase::traceImpl(VisitorDispatcher visitor) {
}
void TraceAfterDispatchExternBase::traceAfterDispatch(Visitor* visitor) {
- traceAfterDispatchImpl(visitor);
-}
-
-void TraceAfterDispatchExternBase::traceAfterDispatch(
- InlinedGlobalMarkingVisitor visitor) {
- traceAfterDispatchImpl(visitor);
-}
-
-template <typename VisitorDispatcher>
-inline void TraceAfterDispatchExternBase::traceAfterDispatchImpl(
- VisitorDispatcher visitor) {
// No trace call.
}
void TraceAfterDispatchExternDerived::traceAfterDispatch(Visitor* visitor) {
- traceAfterDispatchImpl(visitor);
-}
-
-void TraceAfterDispatchExternDerived::traceAfterDispatch(
- InlinedGlobalMarkingVisitor visitor) {
- traceAfterDispatchImpl(visitor);
-}
-
-template <typename VisitorDispatcher>
-inline void TraceAfterDispatchExternDerived::traceAfterDispatchImpl(
- VisitorDispatcher visitor) {
// Ditto.
}

Powered by Google App Engine
This is Rietveld 408576698