tools/clang/blink_gc_plugin/tests/traceimpl_error.txt - Issue 2655933002: blink_gc_plugin: retire overloaded traceImpl detection and handling.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/blink_gc_plugin/tests/traceimpl_error.txt

Issue 2655933002: blink_gc_plugin: retire overloaded traceImpl detection and handling. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 In file included from traceimpl_error.cpp:5:	1 In file included from traceimpl_error.cpp:5:

2 ./traceimpl_error.h:23:3: warning: [blink-gc] Class 'TraceImplInlinedWithUntrace dMember' has untraced fields that require tracing.	2 ./traceimpl_error.h:20:3: warning: [blink-gc] Class 'TraceImplInlinedWithUntrace dMember' has untraced fields that require tracing.

3 void TraceImpl(VisitorDispatcher visitor) {	3 void Trace(Visitor* visitor) {

4 ^	4 ^

5 ./traceimpl_error.h:28:3: note: [blink-gc] Untraced field 'x_' declared here:	5 ./traceimpl_error.h:25:3: note: [blink-gc] Untraced field 'x_' declared here:

6 Member<X> x_;	6 Member<X> x_;

7 ^	7 ^

8 ./traceimpl_error.h:53:3: warning: [blink-gc] Base class 'Base' of derived class 'TraceImplInlineWithUntracedBase' requires tracing.	8 ./traceimpl_error.h:44:3: warning: [blink-gc] Base class 'Base' of derived class 'TraceImplInlineWithUntracedBase' requires tracing.

9 void TraceImpl(VisitorDispatcher visitor) {	9 void Trace(Visitor* visitor) override {

10 ^	10 ^

11 traceimpl_error.cpp:14:1: warning: [blink-gc] Class 'TraceImplExternWithUntraced Member' has untraced fields that require tracing.	11 traceimpl_error.cpp:9:1: warning: [blink-gc] Class 'TraceImplExternWithUntracedM ember' has untraced fields that require tracing.

12 inline void TraceImplExternWithUntracedMember::TraceImpl(	12 void TraceImplExternWithUntracedMember::Trace(Visitor* visitor) {

13 ^	13 ^

14 ./traceimpl_error.h:40:3: note: [blink-gc] Untraced field 'x_' declared here:	14 ./traceimpl_error.h:34:3: note: [blink-gc] Untraced field 'x_' declared here:

15 Member<X> x_;	15 Member<X> x_;

16 ^	16 ^

17 traceimpl_error.cpp:24:1: warning: [blink-gc] Base class 'Base' of derived class 'TraceImplExternWithUntracedBase' requires tracing.	17 traceimpl_error.cpp:13:1: warning: [blink-gc] Base class 'Base' of derived class 'TraceImplExternWithUntracedBase' requires tracing.

18 inline void TraceImplExternWithUntracedBase::TraceImpl(	18 void TraceImplExternWithUntracedBase::Trace(Visitor* visitor) {

19 ^	19 ^

20 4 warnings generated.	20 4 warnings generated.

OLD	NEW