Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: tools/clang/blink_gc_plugin/tests/register_weak_members_template.h

Issue 2655933002: blink_gc_plugin: retire overloaded traceImpl detection and handling. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/register_weak_members_template.h
diff --git a/tools/clang/blink_gc_plugin/tests/register_weak_members_template.h b/tools/clang/blink_gc_plugin/tests/register_weak_members_template.h
index 61d8fbb8d450c154f368efe86bac32bc9c4f18b5..81d917c85538428a503447d8869a5336f728bab9 100644
--- a/tools/clang/blink_gc_plugin/tests/register_weak_members_template.h
+++ b/tools/clang/blink_gc_plugin/tests/register_weak_members_template.h
@@ -11,30 +11,20 @@ namespace blink {
class X : public GarbageCollected<X> {
public:
- void Trace(Visitor* visitor) { TraceImpl(visitor); }
- void Trace(InlinedGlobalMarkingVisitor visitor) { TraceImpl(visitor); }
-
- private:
- template <typename VisitorDispatcher>
- void TraceImpl(VisitorDispatcher visitor) {}
+ void Trace(Visitor* visitor) {}
};
class HasUntracedWeakMembers : public GarbageCollected<HasUntracedWeakMembers> {
public:
- void Trace(Visitor* visitor) { TraceImpl(visitor); }
- void Trace(InlinedGlobalMarkingVisitor visitor) { TraceImpl(visitor); }
-
- // Don't have to be defined for the purpose of this test.
- void clearWeakMembers(Visitor* visitor);
-
- private:
- template <typename VisitorDispatcher>
- void TraceImpl(VisitorDispatcher visitor) {
+ void Trace(Visitor* visitor) {
visitor->template RegisterWeakMembers<
- HasUntracedWeakMembers,
- &HasUntracedWeakMembers::clearWeakMembers>(this);
+ HasUntracedWeakMembers, &HasUntracedWeakMembers::ClearWeakMembers>(
+ this);
}
+ void ClearWeakMembers(Visitor* visitor);
+
+ private:
WeakMember<X> x_;
};

Powered by Google App Engine
This is Rietveld 408576698