Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl.h

Issue 2655933002: blink_gc_plugin: retire overloaded traceImpl detection and handling. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl.h
diff --git a/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl.h b/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl.h
index 64fae26be8649690bce7ce70da103cc34da7c706..57f69c6f8b93b911b6610a0919655015e7858f5d 100644
--- a/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl.h
+++ b/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl.h
@@ -16,12 +16,7 @@ class X : public GarbageCollected<X> {
class TraceImplInlined : public GarbageCollected<TraceImplInlined> {
public:
- void trace(Visitor* visitor) { traceImpl(visitor); }
-
- template <typename VisitorDispatcher>
- void traceImpl(VisitorDispatcher visitor) {
- visitor->trace(x_);
- }
+ void trace(Visitor* visitor) { visitor->trace(x_); }
private:
Member<X> x_;
@@ -30,8 +25,6 @@ class TraceImplInlined : public GarbageCollected<TraceImplInlined> {
class TraceImplExtern : public GarbageCollected<TraceImplExtern> {
public:
void trace(Visitor* visitor);
- template <typename VisitorDispatcher>
- inline void traceImpl(VisitorDispatcher);
private:
Member<X> x_;
@@ -44,21 +37,13 @@ class Base : public GarbageCollected<Base> {
class TraceImplBaseInlined : public Base {
public:
- void trace(Visitor* visitor) override { traceImpl(visitor); }
-
- template <typename VisitorDispatcher>
- void traceImpl(VisitorDispatcher visitor) {
- Base::trace(visitor);
- }
+ void trace(Visitor* visitor) override { Base::trace(visitor); }
};
class TraceImplBaseExtern : public Base {
public:
void trace(Visitor* visitor) override;
- template <typename VisitorDispatcher>
- void traceImpl(VisitorDispatcher);
-
private:
Member<X> x_;
};

Powered by Google App Engine
This is Rietveld 408576698