Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: tools/clang/blink_gc_plugin/tests/traceimpl_overloaded_error.cpp

Issue 2655933002: blink_gc_plugin: retire overloaded traceImpl detection and handling. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/traceimpl_overloaded_error.cpp
diff --git a/tools/clang/blink_gc_plugin/tests/traceimpl_overloaded_error.cpp b/tools/clang/blink_gc_plugin/tests/traceimpl_overloaded_error.cpp
index 80d0f65bc50f89efdae1d3b4e3a36a04a3a23ec6..d0d18e5cbfb20466921ebd6093e8be9eb1731319 100644
--- a/tools/clang/blink_gc_plugin/tests/traceimpl_overloaded_error.cpp
+++ b/tools/clang/blink_gc_plugin/tests/traceimpl_overloaded_error.cpp
@@ -7,28 +7,10 @@
namespace blink {
void ExternBase::Trace(Visitor* visitor) {
- TraceImpl(visitor);
-}
-
-void ExternBase::Trace(InlinedGlobalMarkingVisitor visitor) {
- TraceImpl(visitor);
-}
-
-template <typename VisitorDispatcher>
-inline void ExternBase::TraceImpl(VisitorDispatcher visitor) {
// Missing visitor->Trace(x_base_).
}
void ExternDerived::Trace(Visitor* visitor) {
- TraceImpl(visitor);
-}
-
-void ExternDerived::Trace(InlinedGlobalMarkingVisitor visitor) {
- TraceImpl(visitor);
-}
-
-template <typename VisitorDispatcher>
-inline void ExternDerived::TraceImpl(VisitorDispatcher visitor) {
// Missing visitor->Trace(x_derived_) and ExternBase::Trace(visitor).
}

Powered by Google App Engine
This is Rietveld 408576698