Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: tools/clang/blink_gc_plugin/tests/legacy_naming/register_weak_members_template.h

Issue 2655933002: blink_gc_plugin: retire overloaded traceImpl detection and handling. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/legacy_naming/register_weak_members_template.h
diff --git a/tools/clang/blink_gc_plugin/tests/legacy_naming/register_weak_members_template.h b/tools/clang/blink_gc_plugin/tests/legacy_naming/register_weak_members_template.h
index 7d3905a51df2b02663e69f6f64777d3c0d5d2988..4df3adebdddefd509505faecf4529d8c52f179ee 100644
--- a/tools/clang/blink_gc_plugin/tests/legacy_naming/register_weak_members_template.h
+++ b/tools/clang/blink_gc_plugin/tests/legacy_naming/register_weak_members_template.h
@@ -11,30 +11,20 @@ namespace blink {
class X : public GarbageCollected<X> {
public:
- void trace(Visitor* visitor) { traceImpl(visitor); }
- void trace(InlinedGlobalMarkingVisitor visitor) { traceImpl(visitor); }
-
- private:
- template <typename VisitorDispatcher>
- void traceImpl(VisitorDispatcher visitor) {}
+ void trace(Visitor*) {}
};
class HasUntracedWeakMembers : public GarbageCollected<HasUntracedWeakMembers> {
public:
- void trace(Visitor* visitor) { traceImpl(visitor); }
- void trace(InlinedGlobalMarkingVisitor visitor) { traceImpl(visitor); }
+ void trace(Visitor* visitor) {
+ visitor->registerWeakMembers<HasUntracedWeakMembers,
+ &HasUntracedWeakMembers::clearWeakMembers>(
+ this);
+ }
- // Don't have to be defined for the purpose of this test.
void clearWeakMembers(Visitor* visitor);
private:
- template <typename VisitorDispatcher>
- void traceImpl(VisitorDispatcher visitor) {
- visitor->template registerWeakMembers<
- HasUntracedWeakMembers,
- &HasUntracedWeakMembers::clearWeakMembers>(this);
- }
-
WeakMember<X> x_;
};

Powered by Google App Engine
This is Rietveld 408576698