Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: tools/clang/blink_gc_plugin/tests/trace_after_dispatch_impl.cpp

Issue 2655933002: blink_gc_plugin: retire overloaded traceImpl detection and handling. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/trace_after_dispatch_impl.cpp
diff --git a/tools/clang/blink_gc_plugin/tests/trace_after_dispatch_impl.cpp b/tools/clang/blink_gc_plugin/tests/trace_after_dispatch_impl.cpp
index 17bd1f8b3867626f5484fc52f5355cca82c4077c..c8cd1dfc95fb9879fd171d2c8812f4362b77f2e3 100644
--- a/tools/clang/blink_gc_plugin/tests/trace_after_dispatch_impl.cpp
+++ b/tools/clang/blink_gc_plugin/tests/trace_after_dispatch_impl.cpp
@@ -6,9 +6,7 @@
namespace blink {
-template <typename VisitorDispatcher>
-inline void TraceAfterDispatchInlinedBase::TraceImpl(
- VisitorDispatcher visitor) {
+void TraceAfterDispatchInlinedBase::Trace(Visitor* visitor) {
// Implement a simple form of manual dispatching, because BlinkGCPlugin
// checks if the tracing is dispatched to all derived classes.
//
@@ -23,15 +21,6 @@ inline void TraceAfterDispatchInlinedBase::TraceImpl(
}
void TraceAfterDispatchExternBase::Trace(Visitor* visitor) {
- TraceImpl(visitor);
-}
-
-void TraceAfterDispatchExternBase::Trace(InlinedGlobalMarkingVisitor visitor) {
- TraceImpl(visitor);
-}
-
-template <typename VisitorDispatcher>
-inline void TraceAfterDispatchExternBase::TraceImpl(VisitorDispatcher visitor) {
if (tag_ == DERIVED) {
static_cast<TraceAfterDispatchExternDerived*>(this)->TraceAfterDispatch(
visitor);
@@ -41,32 +30,10 @@ inline void TraceAfterDispatchExternBase::TraceImpl(VisitorDispatcher visitor) {
}
void TraceAfterDispatchExternBase::TraceAfterDispatch(Visitor* visitor) {
- TraceAfterDispatchImpl(visitor);
-}
-
-void TraceAfterDispatchExternBase::TraceAfterDispatch(
- InlinedGlobalMarkingVisitor visitor) {
- TraceAfterDispatchImpl(visitor);
-}
-
-template <typename VisitorDispatcher>
-inline void TraceAfterDispatchExternBase::TraceAfterDispatchImpl(
- VisitorDispatcher visitor) {
visitor->Trace(x_base_);
}
void TraceAfterDispatchExternDerived::TraceAfterDispatch(Visitor* visitor) {
- TraceAfterDispatchImpl(visitor);
-}
-
-void TraceAfterDispatchExternDerived::TraceAfterDispatch(
- InlinedGlobalMarkingVisitor visitor) {
- TraceAfterDispatchImpl(visitor);
-}
-
-template <typename VisitorDispatcher>
-inline void TraceAfterDispatchExternDerived::TraceAfterDispatchImpl(
- VisitorDispatcher visitor) {
visitor->Trace(x_derived_);
TraceAfterDispatchExternBase::TraceAfterDispatch(visitor);
}

Powered by Google App Engine
This is Rietveld 408576698