tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_dependent_scope.txt - Issue 2655933002: blink_gc_plugin: retire overloaded traceImpl detection and handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_dependent_scope.txt

Issue 2655933002: blink_gc_plugin: retire overloaded traceImpl detection and handling. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_dependent_scope.h ('k') | tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_derived_from_templated_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_dependent_scope.txt

diff --git a/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_dependent_scope.txt b/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_dependent_scope.txt

index e1aab335d54c2009705f74d5ea6d2325c156824c..985b7f9605b01c642b5f4bb2a1087cd732cdb9dd 100644

--- a/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_dependent_scope.txt

+++ b/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_dependent_scope.txt

@@ -1,5 +1,5 @@

In file included from traceimpl_dependent_scope.cpp:5:

-./traceimpl_dependent_scope.h:55:3: warning: [blink-gc] Base class 'Base<int>' of derived class 'DerivedMissingTrace<int>' requires tracing.

- void traceImpl(VisitorDispatcher visitor) {

+./traceimpl_dependent_scope.h:32:3: warning: [blink-gc] Base class 'Base<int>' of derived class 'DerivedMissingTrace<int>' requires tracing.

+ void trace(Visitor* visitor) override {

1 warning generated.