blink_gc_plugin: retire overloaded traceImpl detection and handling.

tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "BlinkGCPluginConsumer.h"
 
 #include <algorithm>
 #include <set>
 
 #include "CheckDispatchVisitor.h"
@@ skipping 510 matching lines @@
   }
 
   CheckTraceOrDispatchMethod(parent, method);
 }
 
 void BlinkGCPluginConsumer::CheckTraceOrDispatchMethod(
     RecordInfo* parent,
     CXXMethodDecl* method) {
   Config::TraceMethodType trace_type = Config::GetTraceMethodType(method);
   if (trace_type == Config::TRACE_AFTER_DISPATCH_METHOD ||
-      trace_type == Config::TRACE_AFTER_DISPATCH_IMPL_METHOD ||
       !parent->GetTraceDispatchMethod()) {
     CheckTraceMethod(parent, method, trace_type);
   }
   // Dispatch methods are checked when we identify subclasses.
 }
 
 void BlinkGCPluginConsumer::CheckTraceMethod(
     RecordInfo* parent,
     CXXMethodDecl* trace,
     Config::TraceMethodType trace_type) {
   // A trace method must not override any non-virtual trace methods.
   if (trace_type == Config::TRACE_METHOD) {
     for (auto& base : parent->GetBases())
       if (CXXMethodDecl* other = base.second.info()->InheritsNonVirtualTrace())
         reporter_.OverriddenNonVirtualTrace(parent, trace, other);
   }
 
   CheckTraceVisitor visitor(trace, parent, &cache_);
   visitor.TraverseCXXMethodDecl(trace);
 
-  // Skip reporting if this trace method is a just delegate to
-  // traceImpl (or traceAfterDispatchImpl) method. We will report on
-  // CheckTraceMethod on traceImpl method.
-  if (visitor.delegates_to_traceimpl())
-    return;
-
   for (auto& base : parent->GetBases())
     if (!base.second.IsProperlyTraced())
       reporter_.BaseRequiresTracing(parent, trace, base.first);
 
   for (auto& field : parent->GetFields()) {
     if (!field.second.IsProperlyTraced() ||
         field.second.IsInproperlyTraced()) {
       // Report one or more tracing-related field errors.
       reporter_.FieldsImproperlyTraced(parent, trace);
       break;
@@ skipping 154 matching lines @@
   SourceLocation spelling_location = source_manager.getSpellingLoc(loc);
   PresumedLoc ploc = source_manager.getPresumedLoc(spelling_location);
   if (ploc.isInvalid()) {
     // If we're in an invalid location, we're looking at things that aren't
     // actually stated in the source.
     return false;
   }
   *filename = ploc.getFilename();
   return true;
 }