Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_omitted_trace.h

Issue 2655933002: blink_gc_plugin: retire overloaded traceImpl detection and handling. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_omitted_trace.h
diff --git a/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_omitted_trace.h b/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_omitted_trace.h
index 3c5e9559527d397ab01076a088ff1c234d6db89a..ec5c0b3ef3f53f00939bd8ccf76731d322a9757e 100644
--- a/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_omitted_trace.h
+++ b/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_omitted_trace.h
@@ -11,14 +11,7 @@ namespace blink {
class A : public GarbageCollected<A> {
public:
- virtual void trace(Visitor* visitor) { traceImpl(visitor); }
- virtual void trace(InlinedGlobalMarkingVisitor visitor) {
- traceImpl(visitor);
- }
-
- private:
- template <typename VisitorDispatcher>
- void traceImpl(VisitorDispatcher visitor) {}
+ virtual void trace(Visitor* visitor) {}
};
class B : public A {
@@ -27,14 +20,7 @@ class B : public A {
class C : public B {
public:
- void trace(Visitor* visitor) override { traceImpl(visitor); }
- void trace(InlinedGlobalMarkingVisitor visitor) override {
- traceImpl(visitor);
- }
-
- private:
- template <typename VisitorDispatcher>
- void traceImpl(VisitorDispatcher visitor) {
+ void trace(Visitor* visitor) override {
// B::trace() is actually A::trace(), and in certain cases we only get
// limited information like "there is a function call that will be resolved
// to A::trace()". We still want to mark B as traced.

Powered by Google App Engine
This is Rietveld 408576698