Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_dependent_scope.h

Issue 2655933002: blink_gc_plugin: retire overloaded traceImpl detection and handling. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TRACEIMPL_DEPENDENT_SCOPE_H_ 5 #ifndef TRACEIMPL_DEPENDENT_SCOPE_H_
6 #define TRACEIMPL_DEPENDENT_SCOPE_H_ 6 #define TRACEIMPL_DEPENDENT_SCOPE_H_
7 7
8 #include "heap/stubs.h" 8 #include "heap/stubs.h"
9 9
10 namespace blink { 10 namespace blink {
11 11
12 class X : public GarbageCollected<X> { 12 class X : public GarbageCollected<X> {
13 public: 13 public:
14 virtual void trace(Visitor*) {} 14 virtual void trace(Visitor*) {}
15 }; 15 };
16 16
17 template <typename T> 17 template <typename T>
18 class Base : public GarbageCollected<Base<T> > { 18 class Base : public GarbageCollected<Base<T> > {
19 public: 19 public:
20 virtual void trace(Visitor* visitor) { traceImpl(visitor); } 20 virtual void trace(Visitor*) {}
21 virtual void trace(InlinedGlobalMarkingVisitor visitor) {
22 traceImpl(visitor);
23 }
24
25 private:
26 template <typename VisitorDispatcher>
27 void traceImpl(VisitorDispatcher visitor) {}
28 }; 21 };
29 22
30 template <typename T> 23 template <typename T>
31 class Derived : public Base<T> { 24 class Derived : public Base<T> {
32 public: 25 public:
33 void trace(Visitor* visitor) override { traceImpl(visitor); } 26 void trace(Visitor* visitor) override { Base<T>::trace(visitor); }
34 void trace(InlinedGlobalMarkingVisitor visitor) override {
35 traceImpl(visitor);
36 }
37
38 private:
39 template <typename VisitorDispatcher>
40 void traceImpl(VisitorDispatcher visitor) {
41 Base<T>::trace(visitor);
42 }
43 }; 27 };
44 28
45 template <typename T> 29 template <typename T>
46 class DerivedMissingTrace : public Base<T> { 30 class DerivedMissingTrace : public Base<T> {
47 public: 31 public:
48 void trace(Visitor* visitor) override { traceImpl(visitor); } 32 void trace(Visitor* visitor) override {
49 void trace(InlinedGlobalMarkingVisitor visitor) override {
50 traceImpl(visitor);
51 }
52
53 private:
54 template <typename VisitorDispatcher>
55 void traceImpl(VisitorDispatcher visitor) {
56 // Missing Base<T>::trace(visitor). 33 // Missing Base<T>::trace(visitor).
57 } 34 }
58 }; 35 };
59 36
60 } 37 }
61 38
62 #endif // TRACEIMPL_DEPENDENT_SCOPE_H_ 39 #endif // TRACEIMPL_DEPENDENT_SCOPE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698