tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_derived_from_templated_base.h - Issue 2655933002: blink_gc_plugin: retire overloaded traceImpl detection and handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_derived_from_templated_base.h

Issue 2655933002: blink_gc_plugin: retire overloaded traceImpl detection and handling. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_dependent_scope.txt ('k') | tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_error.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_derived_from_templated_base.h

diff --git a/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_derived_from_templated_base.h b/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_derived_from_templated_base.h

index 21b9978970c9250a37a29882e794a254a583b864..b3825459096aa0c8902c7be071cec4ceb77f8ecc 100644

--- a/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_derived_from_templated_base.h

+++ b/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_derived_from_templated_base.h

@@ -18,12 +18,7 @@ template <int Y>

class TraceImplTemplatedBase

: public GarbageCollected<TraceImplTemplatedBase<Y> > {

public:

- void trace(Visitor* visitor) { traceImpl(visitor); }

- template <typename VisitorDispatcher>

- void traceImpl(VisitorDispatcher visitor) {

- visitor->trace(x_);

- }

+ void trace(Visitor* visitor) { visitor->trace(x_); }

private:

Member<X> x_;