Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1520)

Unified Diff: tools/clang/blink_gc_plugin/tests/traceimpl_dependent_scope.h

Issue 2655933002: blink_gc_plugin: retire overloaded traceImpl detection and handling. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/traceimpl_dependent_scope.h
diff --git a/tools/clang/blink_gc_plugin/tests/traceimpl_dependent_scope.h b/tools/clang/blink_gc_plugin/tests/traceimpl_dependent_scope.h
index 1c54627486af43dfe40cbfe58deb0f3aadb9c43b..631921b1bb6b38b972d385a7aa0437496aed58da 100644
--- a/tools/clang/blink_gc_plugin/tests/traceimpl_dependent_scope.h
+++ b/tools/clang/blink_gc_plugin/tests/traceimpl_dependent_scope.h
@@ -17,42 +17,19 @@ class X : public GarbageCollected<X> {
template <typename T>
class Base : public GarbageCollected<Base<T> > {
public:
- virtual void Trace(Visitor* visitor) { TraceImpl(visitor); }
- virtual void Trace(InlinedGlobalMarkingVisitor visitor) {
- TraceImpl(visitor);
- }
-
- private:
- template <typename VisitorDispatcher>
- void TraceImpl(VisitorDispatcher visitor) {}
+ virtual void Trace(Visitor* visitor) {}
};
template <typename T>
class Derived : public Base<T> {
public:
- void Trace(Visitor* visitor) override { TraceImpl(visitor); }
- void Trace(InlinedGlobalMarkingVisitor visitor) override {
- TraceImpl(visitor);
- }
-
- private:
- template <typename VisitorDispatcher>
- void TraceImpl(VisitorDispatcher visitor) {
- Base<T>::Trace(visitor);
- }
+ void Trace(Visitor* visitor) override { Base<T>::Trace(visitor); }
};
template <typename T>
class DerivedMissingTrace : public Base<T> {
public:
- void Trace(Visitor* visitor) override { TraceImpl(visitor); }
- void Trace(InlinedGlobalMarkingVisitor visitor) override {
- TraceImpl(visitor);
- }
-
- private:
- template <typename VisitorDispatcher>
- void TraceImpl(VisitorDispatcher visitor) {
+ void Trace(Visitor* visitor) override {
// Missing Base<T>::Trace(visitor).
}
};
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/traceimpl.cpp ('k') | tools/clang/blink_gc_plugin/tests/traceimpl_dependent_scope.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698