Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_omitted_trace.h

Issue 2655933002: blink_gc_plugin: retire overloaded traceImpl detection and handling. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TRACEIMPL_OMITTED_TRACE_H_ 5 #ifndef TRACEIMPL_OMITTED_TRACE_H_
6 #define TRACEIMPL_OMITTED_TRACE_H_ 6 #define TRACEIMPL_OMITTED_TRACE_H_
7 7
8 #include "heap/stubs.h" 8 #include "heap/stubs.h"
9 9
10 namespace blink { 10 namespace blink {
11 11
12 class A : public GarbageCollected<A> { 12 class A : public GarbageCollected<A> {
13 public: 13 public:
14 virtual void trace(Visitor* visitor) { traceImpl(visitor); } 14 virtual void trace(Visitor* visitor) {}
15 virtual void trace(InlinedGlobalMarkingVisitor visitor) {
16 traceImpl(visitor);
17 }
18
19 private:
20 template <typename VisitorDispatcher>
21 void traceImpl(VisitorDispatcher visitor) {}
22 }; 15 };
23 16
24 class B : public A { 17 class B : public A {
25 // trace() isn't necessary because we've got nothing to trace here. 18 // trace() isn't necessary because we've got nothing to trace here.
26 }; 19 };
27 20
28 class C : public B { 21 class C : public B {
29 public: 22 public:
30 void trace(Visitor* visitor) override { traceImpl(visitor); } 23 void trace(Visitor* visitor) override {
31 void trace(InlinedGlobalMarkingVisitor visitor) override {
32 traceImpl(visitor);
33 }
34
35 private:
36 template <typename VisitorDispatcher>
37 void traceImpl(VisitorDispatcher visitor) {
38 // B::trace() is actually A::trace(), and in certain cases we only get 24 // B::trace() is actually A::trace(), and in certain cases we only get
39 // limited information like "there is a function call that will be resolved 25 // limited information like "there is a function call that will be resolved
40 // to A::trace()". We still want to mark B as traced. 26 // to A::trace()". We still want to mark B as traced.
41 B::trace(visitor); 27 B::trace(visitor);
42 } 28 }
43 }; 29 };
44 30
45 } 31 }
46 32
47 #endif // TRACEIMPL_OMITTED_TRACE_H_ 33 #endif // TRACEIMPL_OMITTED_TRACE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698