Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: tools/clang/blink_gc_plugin/tests/trace_after_dispatch_impl_error.h

Issue 2655933002: blink_gc_plugin: retire overloaded traceImpl detection and handling. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/trace_after_dispatch_impl_error.h
diff --git a/tools/clang/blink_gc_plugin/tests/trace_after_dispatch_impl_error.h b/tools/clang/blink_gc_plugin/tests/trace_after_dispatch_impl_error.h
index 29f9a8a2a440173aeae2541210d7f237e489f441..00c79867849d6d53f39b697e5d9b07dfbee35327 100644
--- a/tools/clang/blink_gc_plugin/tests/trace_after_dispatch_impl_error.h
+++ b/tools/clang/blink_gc_plugin/tests/trace_after_dispatch_impl_error.h
@@ -23,23 +23,13 @@ class TraceAfterDispatchInlinedBase
public:
explicit TraceAfterDispatchInlinedBase(ClassTag tag) : tag_(tag) {}
- void Trace(Visitor* visitor) { TraceImpl(visitor); }
- void Trace(InlinedGlobalMarkingVisitor visitor) { TraceImpl(visitor); }
+ void Trace(Visitor*);
- void TraceAfterDispatch(Visitor* visitor) { TraceAfterDispatchImpl(visitor); }
- void TraceAfterDispatch(InlinedGlobalMarkingVisitor visitor) {
- TraceAfterDispatchImpl(visitor);
- }
-
- private:
- template <typename VisitorDispatcher>
- void TraceImpl(VisitorDispatcher visitor);
-
- template <typename VisitorDispatcher>
- void TraceAfterDispatchImpl(VisitorDispatcher visitor) {
+ void TraceAfterDispatch(Visitor* visitor) {
// No Trace call; should get a warning.
}
+ private:
ClassTag tag_;
Member<X> x_base_;
};
@@ -48,17 +38,11 @@ class TraceAfterDispatchInlinedDerived : public TraceAfterDispatchInlinedBase {
public:
TraceAfterDispatchInlinedDerived() : TraceAfterDispatchInlinedBase(DERIVED) {}
- void TraceAfterDispatch(Visitor* visitor) { TraceAfterDispatchImpl(visitor); }
- void TraceAfterDispatch(InlinedGlobalMarkingVisitor visitor) {
- TraceAfterDispatchImpl(visitor);
- }
-
- private:
- template <typename VisitorDispatcher>
- void TraceAfterDispatchImpl(VisitorDispatcher visitor) {
+ void TraceAfterDispatch(Visitor* visitor) {
// No Trace call (for member and base class).
}
+ private:
Member<X> x_derived_;
};
@@ -68,18 +52,10 @@ class TraceAfterDispatchExternBase
explicit TraceAfterDispatchExternBase(ClassTag tag) : tag_(tag) {}
void Trace(Visitor* visitor);
- void Trace(InlinedGlobalMarkingVisitor visitor);
void TraceAfterDispatch(Visitor* visitor);
- void TraceAfterDispatch(InlinedGlobalMarkingVisitor visitor);
private:
- template <typename VisitorDispatcher>
- void TraceImpl(VisitorDispatcher visitor);
-
- template <typename VisitorDispatcher>
- void TraceAfterDispatchImpl(VisitorDispatcher visitor);
-
ClassTag tag_;
Member<X> x_base_;
};
@@ -89,12 +65,8 @@ class TraceAfterDispatchExternDerived : public TraceAfterDispatchExternBase {
TraceAfterDispatchExternDerived() : TraceAfterDispatchExternBase(DERIVED) {}
void TraceAfterDispatch(Visitor* visitor);
- void TraceAfterDispatch(InlinedGlobalMarkingVisitor visitor);
private:
- template <typename VisitorDispatcher>
- void TraceAfterDispatchImpl(VisitorDispatcher visitor);
-
Member<X> x_derived_;
};

Powered by Google App Engine
This is Rietveld 408576698