Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_error.txt

Issue 2655933002: blink_gc_plugin: retire overloaded traceImpl detection and handling. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_error.txt
diff --git a/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_error.txt b/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_error.txt
index 070b02961c0953d3fc2ba8674ec4e158fa1471a1..056711a2bb6d4aea8434837109ee5d8fdc0870e9 100644
--- a/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_error.txt
+++ b/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_error.txt
@@ -1,20 +1,20 @@
In file included from traceimpl_error.cpp:5:
-./traceimpl_error.h:23:3: warning: [blink-gc] Class 'TraceImplInlinedWithUntracedMember' has untraced fields that require tracing.
- void traceImpl(VisitorDispatcher visitor) {
+./traceimpl_error.h:20:3: warning: [blink-gc] Class 'TraceImplInlinedWithUntracedMember' has untraced fields that require tracing.
+ void trace(Visitor* visitor) {
^
-./traceimpl_error.h:28:3: note: [blink-gc] Untraced field 'x_' declared here:
+./traceimpl_error.h:25:3: note: [blink-gc] Untraced field 'x_' declared here:
Member<X> x_;
^
-./traceimpl_error.h:53:3: warning: [blink-gc] Base class 'Base' of derived class 'TraceImplInlineWithUntracedBase' requires tracing.
- void traceImpl(VisitorDispatcher visitor) {
+./traceimpl_error.h:44:3: warning: [blink-gc] Base class 'Base' of derived class 'TraceImplInlineWithUntracedBase' requires tracing.
+ void trace(Visitor* visitor) override {
^
-traceimpl_error.cpp:14:1: warning: [blink-gc] Class 'TraceImplExternWithUntracedMember' has untraced fields that require tracing.
-inline void TraceImplExternWithUntracedMember::traceImpl(
+traceimpl_error.cpp:9:1: warning: [blink-gc] Class 'TraceImplExternWithUntracedMember' has untraced fields that require tracing.
+void TraceImplExternWithUntracedMember::trace(Visitor* visitor) {
^
-./traceimpl_error.h:40:3: note: [blink-gc] Untraced field 'x_' declared here:
+./traceimpl_error.h:34:3: note: [blink-gc] Untraced field 'x_' declared here:
Member<X> x_;
^
-traceimpl_error.cpp:24:1: warning: [blink-gc] Base class 'Base' of derived class 'TraceImplExternWithUntracedBase' requires tracing.
-inline void TraceImplExternWithUntracedBase::traceImpl(
+traceimpl_error.cpp:13:1: warning: [blink-gc] Base class 'Base' of derived class 'TraceImplExternWithUntracedBase' requires tracing.
+void TraceImplExternWithUntracedBase::trace(Visitor* visitor) {
^
4 warnings generated.

Powered by Google App Engine
This is Rietveld 408576698