Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 194843004: Move files from ui/views/corewm to ui/wm/core (Closed)

Created:
6 years, 9 months ago by Ben Goodger (Google)
Modified:
6 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, sadrul, nkostylev+watch_chromium.org, tfarina, benquan, Ilya Sherman, ben+corewm_chromium.org, dyu1, dcheng, davemoore+watch_chromium.org, oshima+watch_chromium.org, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org, kalyank, ben+views_chromium.org, James Su, stevenjb+watch_chromium.org, ben+ash_chromium.org, Dane Wallinga
Visibility:
Public.

Description

Patch Set 1 : . #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+484 lines, -9086 lines) Patch
M ash/accelerators/accelerator_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/desktop_background/user_wallpaper_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/dip_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/display/screen_position_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_image_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/ime/candidate_window_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/ime/infolist_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/ime/mode_indicator_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/magnifier/magnification_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/magnifier/partial_magnification_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/root_window_controller.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/shelf/shelf_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shelf/shelf_widget_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shelf/shelf_window_watcher_item_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M ash/shell/content_client/shell_browser_main_parts.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/keyboard_controller_proxy_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/window_type_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/tray_user.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/ash_test_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/test/cursor_manager_test_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/ash_focus_rules.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/ash_native_cursor_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/drag_window_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/drag_window_resizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/drag_window_resizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/immersive_fullscreen_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/immersive_fullscreen_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/lock_state_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/workspace_backdrop_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/scoped_transform_overview_window.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/overview/scoped_window_copy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/overview/window_selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/panels/panel_window_resizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/power_button_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/resize_shadow.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/stacking_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/stacking_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_modal_container_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_modal_container_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/toplevel_window_event_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/video_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_animations.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_animations.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_cycle_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_manager_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ash/wm/window_modality_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/window_positioner.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/multi_window_resize_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_event_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/workspace_controller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/events/event_rewriter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notifications_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/autofill_popup_base_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/desktop_media_picker_views.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_popup.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/desktop_browser_frame_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/screen_capture_notification_ui_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/base/test_launcher_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/view_event_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/menu/menu_host.cc View 1 chunk +1 line, -1 line 0 comments Download
D ui/views/corewm/base_focus_rules.h View 1 chunk +0 lines, -47 lines 0 comments Download
D ui/views/corewm/base_focus_rules.cc View 1 chunk +0 lines, -197 lines 0 comments Download
D ui/views/corewm/capture_controller.h View 1 chunk +0 lines, -88 lines 0 comments Download
D ui/views/corewm/capture_controller.cc View 1 chunk +0 lines, -146 lines 0 comments Download
M ui/views/corewm/capture_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D ui/views/corewm/compound_event_filter.h View 1 chunk +0 lines, -93 lines 0 comments Download
D ui/views/corewm/compound_event_filter.cc View 1 chunk +0 lines, -298 lines 0 comments Download
D ui/views/corewm/compound_event_filter_unittest.cc View 1 chunk +0 lines, -208 lines 0 comments Download
D ui/views/corewm/corewm_switches.h View 1 chunk +0 lines, -26 lines 0 comments Download
D ui/views/corewm/corewm_switches.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D ui/views/corewm/cursor_manager.h View 1 chunk +0 lines, -92 lines 0 comments Download
D ui/views/corewm/cursor_manager.cc View 1 chunk +0 lines, -235 lines 0 comments Download
D ui/views/corewm/cursor_manager_unittest.cc View 1 chunk +0 lines, -353 lines 0 comments Download
M ui/views/corewm/desktop_capture_controller_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D ui/views/corewm/focus_controller.h View 1 chunk +0 lines, -130 lines 0 comments Download
D ui/views/corewm/focus_controller.cc View 1 chunk +0 lines, -379 lines 0 comments Download
D ui/views/corewm/focus_controller_unittest.cc View 1 chunk +0 lines, -1204 lines 0 comments Download
D ui/views/corewm/focus_rules.h View 1 chunk +0 lines, -68 lines 0 comments Download
D ui/views/corewm/image_grid.h View 1 chunk +0 lines, -228 lines 0 comments Download
D ui/views/corewm/image_grid.cc View 1 chunk +0 lines, -308 lines 0 comments Download
D ui/views/corewm/image_grid_unittest.cc View 1 chunk +0 lines, -342 lines 0 comments Download
D ui/views/corewm/input_method_event_filter.h View 1 chunk +0 lines, -55 lines 0 comments Download
D ui/views/corewm/input_method_event_filter.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D ui/views/corewm/input_method_event_filter_unittest.cc View 1 chunk +0 lines, -91 lines 0 comments Download
D ui/views/corewm/native_cursor_manager.h View 1 chunk +0 lines, -67 lines 0 comments Download
D ui/views/corewm/native_cursor_manager_delegate.h View 1 chunk +0 lines, -36 lines 0 comments Download
D ui/views/corewm/shadow.h View 1 chunk +0 lines, -88 lines 0 comments Download
D ui/views/corewm/shadow.cc View 1 chunk +0 lines, -195 lines 0 comments Download
D ui/views/corewm/shadow_controller.h View 1 chunk +0 lines, -71 lines 0 comments Download
D ui/views/corewm/shadow_controller.cc View 1 chunk +0 lines, -274 lines 0 comments Download
D ui/views/corewm/shadow_controller_unittest.cc View 1 chunk +0 lines, -219 lines 0 comments Download
D ui/views/corewm/shadow_types.h View 1 chunk +0 lines, -36 lines 0 comments Download
D ui/views/corewm/shadow_types.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M ui/views/corewm/tooltip_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D ui/views/corewm/transient_window_controller.h View 1 chunk +0 lines, -38 lines 0 comments Download
D ui/views/corewm/transient_window_controller.cc View 1 chunk +0 lines, -42 lines 0 comments Download
D ui/views/corewm/transient_window_manager.h View 1 chunk +0 lines, -104 lines 0 comments Download
D ui/views/corewm/transient_window_manager.cc View 1 chunk +0 lines, -156 lines 0 comments Download
D ui/views/corewm/transient_window_manager_unittest.cc View 1 chunk +0 lines, -638 lines 0 comments Download
D ui/views/corewm/transient_window_observer.h View 1 chunk +0 lines, -34 lines 0 comments Download
D ui/views/corewm/transient_window_stacking_client.h View 1 chunk +0 lines, -39 lines 0 comments Download
D ui/views/corewm/transient_window_stacking_client.cc View 1 chunk +0 lines, -134 lines 0 comments Download
D ui/views/corewm/transient_window_stacking_client_unittest.cc View 1 chunk +0 lines, -217 lines 0 comments Download
D ui/views/corewm/visibility_controller.h View 1 chunk +0 lines, -75 lines 0 comments Download
D ui/views/corewm/visibility_controller.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D ui/views/corewm/visibility_controller_unittest.cc View 1 chunk +0 lines, -59 lines 0 comments Download
D ui/views/corewm/window_animations.h View 1 chunk +0 lines, -104 lines 0 comments Download
D ui/views/corewm/window_animations.cc View 1 chunk +0 lines, -558 lines 0 comments Download
D ui/views/corewm/window_animations_unittest.cc View 1 chunk +0 lines, -143 lines 0 comments Download
D ui/views/corewm/window_modality_controller.h View 1 chunk +0 lines, -73 lines 0 comments Download
D ui/views/corewm/window_modality_controller.cc View 1 chunk +0 lines, -196 lines 0 comments Download
D ui/views/corewm/window_util.h View 1 chunk +0 lines, -69 lines 0 comments Download
D ui/views/corewm/window_util.cc View 1 chunk +0 lines, -131 lines 0 comments Download
D ui/views/corewm/wm_state.h View 1 chunk +0 lines, -34 lines 0 comments Download
D ui/views/corewm/wm_state.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M ui/views/examples/content_client/examples_browser_main_parts.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/examples_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/test/child_modal_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/test/test_views_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/test/views_test_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/view_unittest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ui/views/views.gyp View 5 chunks +53 lines, -52 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_focus_rules.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_focus_rules_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_cursor_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/window/dialog_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
A ui/wm/core/DEPS View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
A + ui/wm/core/base_focus_rules.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + ui/wm/core/base_focus_rules.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + ui/wm/core/capture_controller.h View 4 chunks +6 lines, -6 lines 0 comments Download
A + ui/wm/core/capture_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/wm/core/compound_event_filter.h View 4 chunks +7 lines, -5 lines 0 comments Download
A + ui/wm/core/compound_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/wm/core/compound_event_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/wm/core/cursor_manager.h View 4 chunks +7 lines, -7 lines 0 comments Download
A + ui/wm/core/cursor_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + ui/wm/core/cursor_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/wm/core/focus_controller.h View 4 chunks +8 lines, -8 lines 0 comments Download
A + ui/wm/core/focus_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/wm/core/focus_controller_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/wm/core/focus_rules.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + ui/wm/core/image_grid.h View 4 chunks +6 lines, -6 lines 0 comments Download
A + ui/wm/core/image_grid.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/wm/core/image_grid_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/wm/core/input_method_event_filter.h View 4 chunks +5 lines, -5 lines 0 comments Download
A + ui/wm/core/input_method_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/wm/core/input_method_event_filter_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + ui/wm/core/native_cursor_manager.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + ui/wm/core/native_cursor_manager_delegate.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + ui/wm/core/shadow.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + ui/wm/core/shadow.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/wm/core/shadow_controller.h View 4 chunks +6 lines, -6 lines 0 comments Download
A + ui/wm/core/shadow_controller.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/wm/core/shadow_controller_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + ui/wm/core/shadow_types.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + ui/wm/core/shadow_types.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/wm/core/transient_window_controller.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + ui/wm/core/transient_window_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/wm/core/transient_window_manager.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + ui/wm/core/transient_window_manager.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/wm/core/transient_window_manager_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/wm/core/transient_window_observer.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + ui/wm/core/transient_window_stacking_client.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + ui/wm/core/transient_window_stacking_client.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + ui/wm/core/transient_window_stacking_client_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/wm/core/visibility_controller.h View 3 chunks +8 lines, -7 lines 0 comments Download
A + ui/wm/core/visibility_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/wm/core/visibility_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/wm/core/window_animations.h View 3 chunks +19 lines, -18 lines 0 comments Download
A + ui/wm/core/window_animations.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/wm/core/window_animations_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/wm/core/window_modality_controller.h View 4 chunks +9 lines, -9 lines 0 comments Download
A + ui/wm/core/window_modality_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/wm/core/window_util.h View 3 chunks +21 lines, -19 lines 0 comments Download
A + ui/wm/core/window_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A ui/wm/core/wm_core_export.h View 1 chunk +40 lines, -0 lines 0 comments Download
A + ui/wm/core/wm_core_switches.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + ui/wm/core/wm_core_switches.cc View 2 chunks +2 lines, -3 lines 0 comments Download
A + ui/wm/core/wm_state.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + ui/wm/core/wm_state.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/wm/test/wm_test_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ben Goodger (Google)
6 years, 9 months ago (2014-03-11 20:34:58 UTC) #1
sky
Rubber stamp LGTM https://codereview.chromium.org/194843004/diff/60001/ui/views/DEPS File ui/views/DEPS (right): https://codereview.chromium.org/194843004/diff/60001/ui/views/DEPS#newcode17 ui/views/DEPS:17: "+ui/wm/core", nit: keep sorted.
6 years, 9 months ago (2014-03-11 20:37:49 UTC) #2
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 9 months ago (2014-03-11 21:15:17 UTC) #3
Ben Goodger (Google)
The CQ bit was unchecked by ben@chromium.org
6 years, 9 months ago (2014-03-11 22:00:33 UTC) #4
Ben Goodger (Google)
Committed patchset #4 manually as r256329 (presubmit successful).
6 years, 9 months ago (2014-03-11 22:02:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/194843004/40002
6 years, 9 months ago (2014-03-11 22:15:09 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-11 22:19:39 UTC) #7
Message was sent while issue was closed.
Internal error: failed to checkout. Please try again.

Powered by Google App Engine
This is Rietveld 408576698