Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Issue 1383613002: [net/http auth] Cleanup. Method names, and constness.

Created:
5 years, 2 months ago by asanka
Modified:
5 years, 2 months ago
Reviewers:
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@mock-auth-handler-generalization
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[net/http auth] Cleanup. Method names, and constness. * Rename HttpAuthHandler::InitFromChallenge to HandleAnotherChallenge for consistency with HandleAnotherChallenge method. * Remove unnecessary net:: namespace qualifiers from http_auth code. * Pass HttpAuthChallengeTokenizer as a const reference instead of a non-const pointer through the auth stack. BUG=none

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -233 lines) Patch
M net/android/http_auth_negotiate_android.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M net/android/http_auth_negotiate_android.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M net/android/http_auth_negotiate_android_unittest.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M net/http/http_auth.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_auth_cache_unittest.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M net/http/http_auth_controller.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M net/http/http_auth_gssapi_posix.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_auth_gssapi_posix.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M net/http/http_auth_gssapi_posix_unittest.cc View 1 2 8 chunks +8 lines, -8 lines 0 comments Download
M net/http/http_auth_handler.h View 1 2 5 chunks +16 lines, -17 lines 0 comments Download
M net/http/http_auth_handler.cc View 1 2 3 chunks +13 lines, -14 lines 0 comments Download
M net/http/http_auth_handler_basic.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M net/http/http_auth_handler_basic.cc View 1 2 4 chunks +20 lines, -17 lines 0 comments Download
M net/http/http_auth_handler_basic_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_auth_handler_digest.h View 1 4 chunks +6 lines, -6 lines 0 comments Download
M net/http/http_auth_handler_digest.cc View 1 2 6 chunks +21 lines, -20 lines 0 comments Download
M net/http/http_auth_handler_digest_unittest.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
M net/http/http_auth_handler_factory.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_auth_handler_factory.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M net/http/http_auth_handler_factory_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_auth_handler_mock.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M net/http/http_auth_handler_mock.cc View 1 2 4 chunks +18 lines, -17 lines 0 comments Download
M net/http/http_auth_handler_negotiate.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M net/http/http_auth_handler_negotiate.cc View 1 2 4 chunks +18 lines, -12 lines 0 comments Download
M net/http/http_auth_handler_negotiate_unittest.cc View 1 7 chunks +13 lines, -10 lines 0 comments Download
M net/http/http_auth_handler_ntlm.h View 1 3 chunks +6 lines, -5 lines 0 comments Download
M net/http/http_auth_handler_ntlm.cc View 1 2 3 chunks +13 lines, -8 lines 0 comments Download
M net/http/http_auth_handler_ntlm_portable.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download
M net/http/http_auth_handler_ntlm_win.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download
M net/http/http_auth_handler_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M net/http/http_auth_multi_round_parse.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_auth_multi_round_parse.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M net/http/http_auth_multi_round_parse_unittest.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download
M net/http/http_auth_sspi_win.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_auth_sspi_win.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M net/http/http_auth_sspi_win_unittest.cc View 1 8 chunks +8 lines, -8 lines 0 comments Download
M net/http/http_auth_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_context_builder_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Powered by Google App Engine
This is Rietveld 408576698