[net/http auth] Cleanup. Method names, and constness.

net/http/http_auth_handler_factory.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_AUTH_HANDLER_FACTORY_H_
 #define NET_HTTP_HTTP_AUTH_HANDLER_FACTORY_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 56 matching lines @@
   // |digest_nonce_count| is specifically intended for the Digest authentication
   // scheme, and indicates the number of handlers generated for a particular
   // server nonce challenge.
   //
   // For the NTLM and Negotiate handlers:
   // If |origin| does not match the authentication method's filters for
   // the specified |target|, ERR_INVALID_AUTH_CREDENTIALS is returned.
   // NOTE: This will apply to ALL |origin| values if the filters are empty.
   //
   // |*challenge| should not be reused after a call to |CreateAuthHandler()|,
-  virtual int CreateAuthHandler(HttpAuthChallengeTokenizer* challenge,
+  virtual int CreateAuthHandler(const HttpAuthChallengeTokenizer& challenge,
                                 HttpAuth::Target target,
                                 const GURL& origin,
                                 CreateReason create_reason,
                                 int digest_nonce_count,
                                 const BoundNetLog& net_log,
                                 scoped_ptr<HttpAuthHandler>* handler) = 0;
 
   // Creates an HTTP authentication handler based on the authentication
   // challenge string |challenge|.
   // This is a convenience function which creates a ChallengeTokenizer for
@@ skipping 95 matching lines @@
       const std::vector<std::string>& supported_schemes,
       URLSecurityManager* security_manager,
       HostResolver* host_resolver,
       const std::string& gssapi_library_name,
       const std::string& auth_android_negotiate_account_type,
       bool negotiate_disable_cname_lookup,
       bool negotiate_enable_port);
 
   // Create an auth handler by dispatching the CreateAuthHandler() call to the
   // factory registered to handle challenge->scheme().
-  int CreateAuthHandler(HttpAuthChallengeTokenizer* challenge,
+  int CreateAuthHandler(const HttpAuthChallengeTokenizer& challenge,
                         HttpAuth::Target target,
                         const GURL& origin,
                         CreateReason reason,
                         int digest_nonce_count,
                         const BoundNetLog& net_log,
                         scoped_ptr<HttpAuthHandler>* handler) override;
 
  private:
   typedef std::map<std::string, HttpAuthHandlerFactory*> FactoryMap;
 
   FactoryMap factory_map_;
   DISALLOW_COPY_AND_ASSIGN(HttpAuthHandlerRegistryFactory);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_AUTH_HANDLER_FACTORY_H_