Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1202)

Unified Diff: net/http/http_auth.cc

Issue 1383613002: [net/http auth] Cleanup. Method names, and constness. Base URL: https://chromium.googlesource.com/chromium/src.git@mock-auth-handler-generalization
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/android/http_auth_negotiate_android_unittest.cc ('k') | net/http/http_auth_cache_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth.cc
diff --git a/net/http/http_auth.cc b/net/http/http_auth.cc
index 28fa76b006123a9de1d6464641956b99e34914e0..77b5bdcf472390eaa6d263f035832e64d205ccf4 100644
--- a/net/http/http_auth.cc
+++ b/net/http/http_auth.cc
@@ -109,7 +109,7 @@ void HttpAuth::ChooseBestChallenge(
// priority schemes.
scoped_ptr<HttpAuthHandler> current_handler;
int rv = http_auth_handler_factory->CreateAuthHandler(
- &challenge_tokenizer, target, origin,
+ challenge_tokenizer, target, origin,
HttpAuthHandlerFactory::CREATE_CHALLENGE, 1, net_log, &current_handler);
if (rv != OK) {
net_log.AddEvent(
@@ -148,7 +148,7 @@ HttpAuth::AuthorizationResult HttpAuth::HandleChallengeResponse(
HttpAuthChallengeTokenizer props(challenge.begin(), challenge.end());
if (!props.SchemeIs(current_scheme))
continue;
- authorization_result = handler->HandleAnotherChallenge(&props);
+ authorization_result = handler->HandleAnotherChallenge(props);
if (authorization_result != HttpAuth::AUTHORIZATION_RESULT_INVALID) {
*challenge_used = challenge;
return authorization_result;
« no previous file with comments | « net/android/http_auth_negotiate_android_unittest.cc ('k') | net/http/http_auth_cache_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698