net/http/http_auth_controller.cc - Issue 1383613002: [net/http auth] Cleanup. Method names, and constness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_auth_controller.cc

Issue 1383613002: [net/http auth] Cleanup. Method names, and constness. Base URL: https://chromium.googlesource.com/chromium/src.git@mock-auth-handler-generalization

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_auth_controller.cc

diff --git a/net/http/http_auth_controller.cc b/net/http/http_auth_controller.cc

index 0b3d5c09aed8afb092005d18cddf9202e0dd4266..ea37a41ef2da136e3b10e8f92f997229b979671e 100644

--- a/net/http/http_auth_controller.cc

+++ b/net/http/http_auth_controller.cc

@@ -209,6 +209,7 @@ int HttpAuthController::MaybeGenerateAuthToken(

const HttpRequestInfo* request, const CompletionCallback& callback,

const BoundNetLog& net_log) {

DCHECK(CalledOnValidThread());

+ DCHECK(request);

bool needs_auth = HaveAuth() || SelectPreemptiveAuth(net_log);

if (!needs_auth)

return OK;

@@ -218,7 +219,7 @@ int HttpAuthController::MaybeGenerateAuthToken(

DCHECK(auth_token_.empty());

DCHECK(callback_.is_null());

int rv = handler_->GenerateAuthToken(

- credentials, request,

+ credentials, *request,

base::Bind(&HttpAuthController::OnIOComplete, base::Unretained(this)),

&auth_token_);

if (DisableOnAuthHandlerResult(rv))

« no previous file with comments | « net/http/http_auth_cache_unittest.cc ('k') | net/http/http_auth_gssapi_posix.h » ('j') | no next file with comments »