Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1321)

Unified Diff: net/http/http_auth_multi_round_parse_unittest.cc

Issue 1383613002: [net/http auth] Cleanup. Method names, and constness. Base URL: https://chromium.googlesource.com/chromium/src.git@mock-auth-handler-generalization
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth_multi_round_parse.cc ('k') | net/http/http_auth_sspi_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_multi_round_parse_unittest.cc
diff --git a/net/http/http_auth_multi_round_parse_unittest.cc b/net/http/http_auth_multi_round_parse_unittest.cc
index 1be5ad1f5dcfa84fe7dc0b5c851dd0e3e7d72337..022212a08aeafe21a69ab82d626a170be9a61f5c 100644
--- a/net/http/http_auth_multi_round_parse_unittest.cc
+++ b/net/http/http_auth_multi_round_parse_unittest.cc
@@ -15,7 +15,7 @@ TEST(HttpAuthHandlerNegotiateParseTest, ParseFirstRoundChallenge) {
HttpAuthChallengeTokenizer challenge(challenge_text.begin(),
challenge_text.end());
EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_ACCEPT,
- ParseFirstRoundChallenge("dummyscheme", &challenge));
+ ParseFirstRoundChallenge("dummyscheme", challenge));
}
TEST(HttpAuthHandlerNegotiateParseTest,
@@ -26,7 +26,7 @@ TEST(HttpAuthHandlerNegotiateParseTest,
HttpAuthChallengeTokenizer challenge(challenge_text.begin(),
challenge_text.end());
EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_INVALID,
- ParseFirstRoundChallenge("negotiate", &challenge));
+ ParseFirstRoundChallenge("negotiate", challenge));
}
TEST(HttpAuthHandlerNegotiateParseTest,
@@ -35,7 +35,7 @@ TEST(HttpAuthHandlerNegotiateParseTest,
HttpAuthChallengeTokenizer challenge(challenge_text.begin(),
challenge_text.end());
EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_INVALID,
- ParseFirstRoundChallenge("negotiate", &challenge));
+ ParseFirstRoundChallenge("negotiate", challenge));
}
TEST(HttpAuthHandlerNegotiateParseTest, ParseLaterRoundChallenge) {
@@ -46,7 +46,7 @@ TEST(HttpAuthHandlerNegotiateParseTest, ParseLaterRoundChallenge) {
std::string encoded_token;
std::string decoded_token;
EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_ACCEPT,
- ParseLaterRoundChallenge("negotiate", &challenge, &encoded_token,
+ ParseLaterRoundChallenge("negotiate", challenge, &encoded_token,
&decoded_token));
EXPECT_EQ("Zm9vYmFy", encoded_token);
EXPECT_EQ("foobar", decoded_token);
@@ -60,7 +60,7 @@ TEST(HttpAuthHandlerNegotiateParseTest,
std::string encoded_token;
std::string decoded_token;
EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_REJECT,
- ParseLaterRoundChallenge("negotiate", &challenge, &encoded_token,
+ ParseLaterRoundChallenge("negotiate", challenge, &encoded_token,
&decoded_token));
}
@@ -72,7 +72,7 @@ TEST(HttpAuthHandlerNegotiateParseTest,
std::string encoded_token;
std::string decoded_token;
EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_INVALID,
- ParseLaterRoundChallenge("negotiate", &challenge, &encoded_token,
+ ParseLaterRoundChallenge("negotiate", challenge, &encoded_token,
&decoded_token));
}
}
« no previous file with comments | « net/http/http_auth_multi_round_parse.cc ('k') | net/http/http_auth_sspi_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698