[net/http auth] Cleanup. Method names, and constness.

net/http/http_auth_handler_negotiate.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_AUTH_HANDLER_NEGOTIATE_H_
 #define NET_HTTP_HTTP_AUTH_HANDLER_NEGOTIATE_H_
 
 #include <string>
 
 #include "build/build_config.h"
@@ skipping 58 matching lines @@
     void set_use_port(bool use_port) { use_port_ = use_port; }
 
     void set_host_resolver(HostResolver* host_resolver);
 
     // Sets the system library to use, thereby assuming ownership of
     // |auth_library|.
     void set_library(AuthLibrary* auth_provider) {
       auth_library_.reset(auth_provider);
     }
 
-    int CreateAuthHandler(HttpAuthChallengeTokenizer* challenge,
+    int CreateAuthHandler(const HttpAuthChallengeTokenizer& challenge,
                           HttpAuth::Target target,
                           const GURL& origin,
                           CreateReason reason,
                           int digest_nonce_count,
                           const BoundNetLog& net_log,
                           scoped_ptr<HttpAuthHandler>* handler) override;
 
    private:
     bool disable_cname_lookup_;
     bool use_port_;
@@ skipping 15 matching lines @@
                            bool use_port);
 
   ~HttpAuthHandlerNegotiate() override;
 
   // These are public for unit tests
   std::string CreateSPN(const AddressList& address_list, const GURL& orign);
   const std::string& spn() const { return spn_; }
 
   // HttpAuthHandler:
   HttpAuth::AuthorizationResult HandleAnotherChallenge(
-      HttpAuthChallengeTokenizer* challenge) override;
+      const HttpAuthChallengeTokenizer& challenge) override;
   bool NeedsIdentity() override;
   bool AllowsDefaultCredentials() override;
   bool AllowsExplicitCredentials() override;
 
  protected:
-  bool Init(HttpAuthChallengeTokenizer* challenge) override;
+  int Init(const HttpAuthChallengeTokenizer& challenge) override;
 
   int GenerateAuthTokenImpl(const AuthCredentials* credentials,
-                            const HttpRequestInfo* request,
+                            const HttpRequestInfo& request,
                             const CompletionCallback& callback,
                             std::string* auth_token) override;
 
  private:
   enum State {
     STATE_RESOLVE_CANONICAL_NAME,
     STATE_RESOLVE_CANONICAL_NAME_COMPLETE,
     STATE_GENERATE_AUTH_TOKEN,
     STATE_GENERATE_AUTH_TOKEN_COMPLETE,
     STATE_NONE,
@@ skipping 29 matching lines @@
   std::string* auth_token_;
 
   State next_state_;
 
   const URLSecurityManager* url_security_manager_;
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_AUTH_HANDLER_NEGOTIATE_H_