net/http/http_auth_multi_round_parse.h - Issue 1383613002: [net/http auth] Cleanup. Method names, and constness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_auth_multi_round_parse.h

Issue 1383613002: [net/http auth] Cleanup. Method names, and constness. Base URL: https://chromium.googlesource.com/chromium/src.git@mock-auth-handler-generalization

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_auth_multi_round_parse.h

diff --git a/net/http/http_auth_multi_round_parse.h b/net/http/http_auth_multi_round_parse.h

index 2fb63473d1a09e3c014dc55b10beb8a5576d0745..6f05082ed6d84f51a3aec1e9f441201278016d1b 100644

--- a/net/http/http_auth_multi_round_parse.h

+++ b/net/http/http_auth_multi_round_parse.h

@@ -16,11 +16,11 @@ class HttpAuthChallengeTokenizer;

NET_EXPORT_PRIVATE HttpAuth::AuthorizationResult ParseFirstRoundChallenge(

const std::string& scheme,

- HttpAuthChallengeTokenizer* challenge);

+ const HttpAuthChallengeTokenizer& challenge);

NET_EXPORT_PRIVATE HttpAuth::AuthorizationResult ParseLaterRoundChallenge(

const std::string& scheme,

- HttpAuthChallengeTokenizer* challenge,

+ const HttpAuthChallengeTokenizer& challenge,

std::string* encoded_token,

std::string* decoded_token);

« no previous file with comments | « net/http/http_auth_handler_unittest.cc ('k') | net/http/http_auth_multi_round_parse.cc » ('j') | no next file with comments »