Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: net/http/http_auth_gssapi_posix_unittest.cc

Issue 1383613002: [net/http auth] Cleanup. Method names, and constness. Base URL: https://chromium.googlesource.com/chromium/src.git@mock-auth-handler-generalization
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth_gssapi_posix.cc ('k') | net/http/http_auth_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_gssapi_posix_unittest.cc
diff --git a/net/http/http_auth_gssapi_posix_unittest.cc b/net/http/http_auth_gssapi_posix_unittest.cc
index 3531bb8deb17a9345afdd4bbde1084359f64e293..63333208b7b7b6148914f518c590be6dfeb27654 100644
--- a/net/http/http_auth_gssapi_posix_unittest.cc
+++ b/net/http/http_auth_gssapi_posix_unittest.cc
@@ -191,7 +191,7 @@ TEST(HttpAuthGSSAPITest, ParseChallenge_FirstRound) {
HttpAuthChallengeTokenizer challenge(challenge_text.begin(),
challenge_text.end());
EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_ACCEPT,
- auth_gssapi.ParseChallenge(&challenge));
+ auth_gssapi.ParseChallenge(challenge));
}
TEST(HttpAuthGSSAPITest, ParseChallenge_TwoRounds) {
@@ -204,7 +204,7 @@ TEST(HttpAuthGSSAPITest, ParseChallenge_TwoRounds) {
HttpAuthChallengeTokenizer first_challenge(first_challenge_text.begin(),
first_challenge_text.end());
EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_ACCEPT,
- auth_gssapi.ParseChallenge(&first_challenge));
+ auth_gssapi.ParseChallenge(first_challenge));
// Generate an auth token and create another thing.
EstablishInitialContext(&mock_library);
@@ -217,7 +217,7 @@ TEST(HttpAuthGSSAPITest, ParseChallenge_TwoRounds) {
HttpAuthChallengeTokenizer second_challenge(second_challenge_text.begin(),
second_challenge_text.end());
EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_ACCEPT,
- auth_gssapi.ParseChallenge(&second_challenge));
+ auth_gssapi.ParseChallenge(second_challenge));
}
TEST(HttpAuthGSSAPITest, ParseChallenge_UnexpectedTokenFirstRound) {
@@ -230,7 +230,7 @@ TEST(HttpAuthGSSAPITest, ParseChallenge_UnexpectedTokenFirstRound) {
HttpAuthChallengeTokenizer challenge(challenge_text.begin(),
challenge_text.end());
EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_INVALID,
- auth_gssapi.ParseChallenge(&challenge));
+ auth_gssapi.ParseChallenge(challenge));
}
TEST(HttpAuthGSSAPITest, ParseChallenge_MissingTokenSecondRound) {
@@ -243,7 +243,7 @@ TEST(HttpAuthGSSAPITest, ParseChallenge_MissingTokenSecondRound) {
HttpAuthChallengeTokenizer first_challenge(first_challenge_text.begin(),
first_challenge_text.end());
EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_ACCEPT,
- auth_gssapi.ParseChallenge(&first_challenge));
+ auth_gssapi.ParseChallenge(first_challenge));
EstablishInitialContext(&mock_library);
std::string auth_token;
@@ -254,7 +254,7 @@ TEST(HttpAuthGSSAPITest, ParseChallenge_MissingTokenSecondRound) {
HttpAuthChallengeTokenizer second_challenge(second_challenge_text.begin(),
second_challenge_text.end());
EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_REJECT,
- auth_gssapi.ParseChallenge(&second_challenge));
+ auth_gssapi.ParseChallenge(second_challenge));
}
TEST(HttpAuthGSSAPITest, ParseChallenge_NonBase64EncodedToken) {
@@ -267,7 +267,7 @@ TEST(HttpAuthGSSAPITest, ParseChallenge_NonBase64EncodedToken) {
HttpAuthChallengeTokenizer first_challenge(first_challenge_text.begin(),
first_challenge_text.end());
EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_ACCEPT,
- auth_gssapi.ParseChallenge(&first_challenge));
+ auth_gssapi.ParseChallenge(first_challenge));
EstablishInitialContext(&mock_library);
std::string auth_token;
@@ -278,7 +278,7 @@ TEST(HttpAuthGSSAPITest, ParseChallenge_NonBase64EncodedToken) {
HttpAuthChallengeTokenizer second_challenge(second_challenge_text.begin(),
second_challenge_text.end());
EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_INVALID,
- auth_gssapi.ParseChallenge(&second_challenge));
+ auth_gssapi.ParseChallenge(second_challenge));
}
} // namespace net
« no previous file with comments | « net/http/http_auth_gssapi_posix.cc ('k') | net/http/http_auth_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698