Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: net/http/http_auth_sspi_win_unittest.cc

Issue 1383613002: [net/http auth] Cleanup. Method names, and constness. Base URL: https://chromium.googlesource.com/chromium/src.git@mock-auth-handler-generalization
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth_sspi_win.cc ('k') | net/http/http_auth_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_sspi_win_unittest.cc
diff --git a/net/http/http_auth_sspi_win_unittest.cc b/net/http/http_auth_sspi_win_unittest.cc
index feebaf0cee1e0664151e9fd5c671ee4b3c51eafd..8b8de7b278eea53f0c3073b45d97cd6d03333cb5 100644
--- a/net/http/http_auth_sspi_win_unittest.cc
+++ b/net/http/http_auth_sspi_win_unittest.cc
@@ -72,7 +72,7 @@ TEST(HttpAuthSSPITest, ParseChallenge_FirstRound) {
HttpAuthChallengeTokenizer challenge(challenge_text.begin(),
challenge_text.end());
EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_ACCEPT,
- auth_sspi.ParseChallenge(&challenge));
+ auth_sspi.ParseChallenge(challenge));
}
TEST(HttpAuthSSPITest, ParseChallenge_TwoRounds) {
@@ -85,7 +85,7 @@ TEST(HttpAuthSSPITest, ParseChallenge_TwoRounds) {
HttpAuthChallengeTokenizer first_challenge(first_challenge_text.begin(),
first_challenge_text.end());
EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_ACCEPT,
- auth_sspi.ParseChallenge(&first_challenge));
+ auth_sspi.ParseChallenge(first_challenge));
// Generate an auth token and create another thing.
std::string auth_token;
@@ -97,7 +97,7 @@ TEST(HttpAuthSSPITest, ParseChallenge_TwoRounds) {
HttpAuthChallengeTokenizer second_challenge(second_challenge_text.begin(),
second_challenge_text.end());
EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_ACCEPT,
- auth_sspi.ParseChallenge(&second_challenge));
+ auth_sspi.ParseChallenge(second_challenge));
}
TEST(HttpAuthSSPITest, ParseChallenge_UnexpectedTokenFirstRound) {
@@ -110,7 +110,7 @@ TEST(HttpAuthSSPITest, ParseChallenge_UnexpectedTokenFirstRound) {
HttpAuthChallengeTokenizer challenge(challenge_text.begin(),
challenge_text.end());
EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_INVALID,
- auth_sspi.ParseChallenge(&challenge));
+ auth_sspi.ParseChallenge(challenge));
}
TEST(HttpAuthSSPITest, ParseChallenge_MissingTokenSecondRound) {
@@ -123,7 +123,7 @@ TEST(HttpAuthSSPITest, ParseChallenge_MissingTokenSecondRound) {
HttpAuthChallengeTokenizer first_challenge(first_challenge_text.begin(),
first_challenge_text.end());
EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_ACCEPT,
- auth_sspi.ParseChallenge(&first_challenge));
+ auth_sspi.ParseChallenge(first_challenge));
std::string auth_token;
EXPECT_EQ(OK, auth_sspi.GenerateAuthToken(NULL, "HTTP/intranet.google.com",
@@ -133,7 +133,7 @@ TEST(HttpAuthSSPITest, ParseChallenge_MissingTokenSecondRound) {
HttpAuthChallengeTokenizer second_challenge(second_challenge_text.begin(),
second_challenge_text.end());
EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_REJECT,
- auth_sspi.ParseChallenge(&second_challenge));
+ auth_sspi.ParseChallenge(second_challenge));
}
TEST(HttpAuthSSPITest, ParseChallenge_NonBase64EncodedToken) {
@@ -146,7 +146,7 @@ TEST(HttpAuthSSPITest, ParseChallenge_NonBase64EncodedToken) {
HttpAuthChallengeTokenizer first_challenge(first_challenge_text.begin(),
first_challenge_text.end());
EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_ACCEPT,
- auth_sspi.ParseChallenge(&first_challenge));
+ auth_sspi.ParseChallenge(first_challenge));
std::string auth_token;
EXPECT_EQ(OK, auth_sspi.GenerateAuthToken(NULL, "HTTP/intranet.google.com",
@@ -156,7 +156,7 @@ TEST(HttpAuthSSPITest, ParseChallenge_NonBase64EncodedToken) {
HttpAuthChallengeTokenizer second_challenge(second_challenge_text.begin(),
second_challenge_text.end());
EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_INVALID,
- auth_sspi.ParseChallenge(&second_challenge));
+ auth_sspi.ParseChallenge(second_challenge));
}
} // namespace net
« no previous file with comments | « net/http/http_auth_sspi_win.cc ('k') | net/http/http_auth_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698