Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1677)

Unified Diff: net/http/http_auth_handler_negotiate_unittest.cc

Issue 1383613002: [net/http auth] Cleanup. Method names, and constness. Base URL: https://chromium.googlesource.com/chromium/src.git@mock-auth-handler-generalization
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth_handler_negotiate.cc ('k') | net/http/http_auth_handler_ntlm.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_handler_negotiate_unittest.cc
diff --git a/net/http/http_auth_handler_negotiate_unittest.cc b/net/http/http_auth_handler_negotiate_unittest.cc
index 49ebdad62adb5173e02d99f1bd679bcb662e4cad..f9950489e24d4efc05c5f0be64dcb9324f1600f8 100644
--- a/net/http/http_auth_handler_negotiate_unittest.cc
+++ b/net/http/http_auth_handler_negotiate_unittest.cc
@@ -242,7 +242,7 @@ TEST_F(HttpAuthHandlerNegotiateTest, DisableCname) {
HttpRequestInfo request_info;
std::string token;
EXPECT_EQ(OK, callback.GetResult(auth_handler->GenerateAuthToken(
- NULL, &request_info, callback.callback(), &token)));
+ NULL, request_info, callback.callback(), &token)));
#if defined(OS_WIN)
EXPECT_EQ("HTTP/alias", auth_handler->spn());
#elif defined(OS_POSIX)
@@ -260,7 +260,7 @@ TEST_F(HttpAuthHandlerNegotiateTest, DisableCnameStandardPort) {
HttpRequestInfo request_info;
std::string token;
EXPECT_EQ(OK, callback.GetResult(auth_handler->GenerateAuthToken(
- NULL, &request_info, callback.callback(), &token)));
+ NULL, request_info, callback.callback(), &token)));
#if defined(OS_WIN)
EXPECT_EQ("HTTP/alias", auth_handler->spn());
#elif defined(OS_POSIX)
@@ -278,7 +278,7 @@ TEST_F(HttpAuthHandlerNegotiateTest, DisableCnameNonstandardPort) {
HttpRequestInfo request_info;
std::string token;
EXPECT_EQ(OK, callback.GetResult(auth_handler->GenerateAuthToken(
- NULL, &request_info, callback.callback(), &token)));
+ NULL, request_info, callback.callback(), &token)));
#if defined(OS_WIN)
EXPECT_EQ("HTTP/alias:500", auth_handler->spn());
#elif defined(OS_POSIX)
@@ -296,7 +296,7 @@ TEST_F(HttpAuthHandlerNegotiateTest, CnameSync) {
HttpRequestInfo request_info;
std::string token;
EXPECT_EQ(OK, callback.GetResult(auth_handler->GenerateAuthToken(
- NULL, &request_info, callback.callback(), &token)));
+ NULL, request_info, callback.callback(), &token)));
#if defined(OS_WIN)
EXPECT_EQ("HTTP/canonical.example.com", auth_handler->spn());
#elif defined(OS_POSIX)
@@ -313,8 +313,9 @@ TEST_F(HttpAuthHandlerNegotiateTest, CnameAsync) {
TestCompletionCallback callback;
HttpRequestInfo request_info;
std::string token;
- EXPECT_EQ(ERR_IO_PENDING, auth_handler->GenerateAuthToken(
- NULL, &request_info, callback.callback(), &token));
+ EXPECT_EQ(ERR_IO_PENDING,
+ auth_handler->GenerateAuthToken(NULL, request_info,
+ callback.callback(), &token));
EXPECT_EQ(OK, callback.WaitForResult());
#if defined(OS_WIN)
EXPECT_EQ("HTTP/canonical.example.com", auth_handler->spn());
@@ -336,8 +337,9 @@ TEST_F(HttpAuthHandlerNegotiateTest, ServerNotInKerberosDatabase) {
TestCompletionCallback callback;
HttpRequestInfo request_info;
std::string token;
- EXPECT_EQ(ERR_IO_PENDING, auth_handler->GenerateAuthToken(
- NULL, &request_info, callback.callback(), &token));
+ EXPECT_EQ(ERR_IO_PENDING,
+ auth_handler->GenerateAuthToken(NULL, request_info,
+ callback.callback(), &token));
EXPECT_EQ(ERR_MISSING_AUTH_CREDENTIALS, callback.WaitForResult());
}
@@ -352,8 +354,9 @@ TEST_F(HttpAuthHandlerNegotiateTest, NoKerberosCredentials) {
TestCompletionCallback callback;
HttpRequestInfo request_info;
std::string token;
- EXPECT_EQ(ERR_IO_PENDING, auth_handler->GenerateAuthToken(
- NULL, &request_info, callback.callback(), &token));
+ EXPECT_EQ(ERR_IO_PENDING,
+ auth_handler->GenerateAuthToken(NULL, request_info,
+ callback.callback(), &token));
EXPECT_EQ(ERR_MISSING_AUTH_CREDENTIALS, callback.WaitForResult());
}
« no previous file with comments | « net/http/http_auth_handler_negotiate.cc ('k') | net/http/http_auth_handler_ntlm.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698