[net/http auth] Cleanup. Method names, and constness.

net/http/http_auth_cache_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/strings/string16.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 13 matching lines @@
   MockAuthHandler(const std::string& scheme,
                   const std::string& realm,
                   HttpAuth::Target target) {
     // Can't use initializer list since these are members of the base class.
     auth_scheme_ = scheme;
     realm_ = realm;
     target_ = target;
   }
 
   HttpAuth::AuthorizationResult HandleAnotherChallenge(
-      HttpAuthChallengeTokenizer* challenge) override {
+      const HttpAuthChallengeTokenizer& challenge) override {
     return HttpAuth::AUTHORIZATION_RESULT_REJECT;
   }
 
  protected:
-  bool Init(HttpAuthChallengeTokenizer* challenge) override {
-    return false;  // Unused.
+  int Init(const HttpAuthChallengeTokenizer& challenge) override {
+    return ERR_UNEXPECTED;  // Unused.
   }
 
   int GenerateAuthTokenImpl(const AuthCredentials*,
-                            const HttpRequestInfo*,
+                            const HttpRequestInfo&,
                             const CompletionCallback& callback,
                             std::string* auth_token) override {
     *auth_token = "mock-credentials";
     return OK;
   }
 
 
  private:
   ~MockAuthHandler() override {}
 };
@@ skipping 520 matching lines @@
     CheckPathExistence(0, i, false);
 
   for (int i = 0; i < kMaxPaths; ++i)
     CheckPathExistence(0, i + 3, true);
 
   for (int i = 0; i < kMaxRealms; ++i)
     CheckRealmExistence(i, true);
 }
 
 }  // namespace net