Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: net/http/http_auth_cache_unittest.cc

Issue 1383613002: [net/http auth] Cleanup. Method names, and constness. Base URL: https://chromium.googlesource.com/chromium/src.git@mock-auth-handler-generalization
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth.cc ('k') | net/http/http_auth_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_cache_unittest.cc
diff --git a/net/http/http_auth_cache_unittest.cc b/net/http/http_auth_cache_unittest.cc
index 65bf17dd066d6a30efb0abe32330ae9037be6d78..1b8a5c89fb802129182742a44ee1d486a6a07231 100644
--- a/net/http/http_auth_cache_unittest.cc
+++ b/net/http/http_auth_cache_unittest.cc
@@ -31,17 +31,17 @@ class MockAuthHandler : public HttpAuthHandler {
}
HttpAuth::AuthorizationResult HandleAnotherChallenge(
- HttpAuthChallengeTokenizer* challenge) override {
+ const HttpAuthChallengeTokenizer& challenge) override {
return HttpAuth::AUTHORIZATION_RESULT_REJECT;
}
protected:
- bool Init(HttpAuthChallengeTokenizer* challenge) override {
- return false; // Unused.
+ int Init(const HttpAuthChallengeTokenizer& challenge) override {
+ return ERR_UNEXPECTED; // Unused.
}
int GenerateAuthTokenImpl(const AuthCredentials*,
- const HttpRequestInfo*,
+ const HttpRequestInfo&,
const CompletionCallback& callback,
std::string* auth_token) override {
*auth_token = "mock-credentials";
« no previous file with comments | « net/http/http_auth.cc ('k') | net/http/http_auth_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698