Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1393693002: [net/http auth] Split HttpAuthHandler creation from initialization.

Created:
5 years, 2 months ago by asanka
Modified:
5 years, 2 months ago
Reviewers:
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@rename-auth-handler-methods
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[net/http auth] Split HttpAuthHandler creation from initialization. HttpAuthHandler initialization often requires blocking operations to be performed. Currently these blocking operations are done on the IO thread. This split is in preparation for the making HttpAuthHandler initialization asynchronous in a subsequent CL. BUG=66702

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+636 lines, -572 lines) Patch
M net/http/http_auth.cc View 1 chunk +10 lines, -3 lines 0 comments Download
M net/http/http_auth_cache_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_auth_controller.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M net/http/http_auth_controller_unittest.cc View 5 chunks +5 lines, -9 lines 0 comments Download
M net/http/http_auth_handler.h View 3 chunks +93 lines, -35 lines 0 comments Download
M net/http/http_auth_handler.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M net/http/http_auth_handler_basic.h View 1 chunk +13 lines, -10 lines 0 comments Download
M net/http/http_auth_handler_basic.cc View 3 chunks +26 lines, -17 lines 0 comments Download
M net/http/http_auth_handler_basic_unittest.cc View 4 chunks +51 lines, -17 lines 0 comments Download
M net/http/http_auth_handler_digest.h View 3 chunks +9 lines, -8 lines 0 comments Download
M net/http/http_auth_handler_digest.cc View 6 chunks +44 lines, -39 lines 0 comments Download
M net/http/http_auth_handler_digest_unittest.cc View 6 chunks +60 lines, -41 lines 0 comments Download
M net/http/http_auth_handler_factory.h View 5 chunks +20 lines, -37 lines 0 comments Download
M net/http/http_auth_handler_factory.cc View 2 chunks +21 lines, -42 lines 0 comments Download
M net/http/http_auth_handler_factory_unittest.cc View 7 chunks +80 lines, -94 lines 0 comments Download
M net/http/http_auth_handler_mock.h View 5 chunks +21 lines, -16 lines 0 comments Download
M net/http/http_auth_handler_mock.cc View 4 chunks +44 lines, -36 lines 0 comments Download
M net/http/http_auth_handler_negotiate.h View 1 chunk +8 lines, -7 lines 0 comments Download
M net/http/http_auth_handler_negotiate.cc View 3 chunks +34 lines, -31 lines 0 comments Download
M net/http/http_auth_handler_negotiate_unittest.cc View 2 chunks +10 lines, -6 lines 0 comments Download
M net/http/http_auth_handler_ntlm.h View 3 chunks +11 lines, -12 lines 0 comments Download
M net/http/http_auth_handler_ntlm.cc View 3 chunks +11 lines, -1 line 0 comments Download
M net/http/http_auth_handler_ntlm_portable.cc View 2 chunks +11 lines, -22 lines 0 comments Download
M net/http/http_auth_handler_ntlm_win.cc View 2 chunks +15 lines, -25 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 4 chunks +6 lines, -10 lines 0 comments Download
M net/url_request/url_request_context_builder_unittest.cc View 3 chunks +21 lines, -37 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Powered by Google App Engine
This is Rietveld 408576698