Issue 1381493004: [net/http auth] Generalize HttpAuthHandlerMock.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1381493004: [net/http auth] Generalize HttpAuthHandlerMock.

Created:
5 years, 2 months ago by asanka

Modified:
5 years, 2 months ago

Reviewers:

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@http-auth-scheme-properties

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[net/http auth] Generalize HttpAuthHandlerMock. This change: * Allows HttpAuthHandlerMock to impersonate any authentication scheme. * Adds test expectations to verify HttpAuthHandler API contract invariants. * Uses scoped_ptr<> types to pass ownership of HttpAuthHandlers to HttpAuthHandlerMock::Factory. * Updates HttpAuthHandlerMock to generate RFC 7235 compliant authentication tokens. BUG=270219

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+174 lines, -246 lines)			Patch
M	net/http/http_auth_controller_unittest.cc	View	1	5 chunks	+25 lines, -51 lines	0 comments	Download
M	net/http/http_auth_handler_mock.h	View	1	6 chunks	+21 lines, -32 lines	0 comments	Download
M	net/http/http_auth_handler_mock.cc	View	1	5 chunks	+53 lines, -74 lines	0 comments	Download
M	net/http/http_auth_unittest.cc	View	1	2 chunks	+7 lines, -12 lines	0 comments	Download
M	net/http/http_network_transaction_unittest.cc	View	1	13 chunks	+68 lines, -77 lines	0 comments	Download

Depends on Patchset:

Issue 1157333005 Patch 60001

Dependent Patchsets:

Issue 1383613002 Patch 40001