[net/http auth] Cleanup. Method names, and constness.

net/http/http_auth_handler_digest.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_AUTH_HANDLER_DIGEST_H_
 #define NET_HTTP_HTTP_AUTH_HANDLER_DIGEST_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 47 matching lines @@
   };
 
   class NET_EXPORT_PRIVATE Factory : public HttpAuthHandlerFactory {
    public:
     Factory();
     ~Factory() override;
 
     // This factory owns the passed in |nonce_generator|.
     void set_nonce_generator(const NonceGenerator* nonce_generator);
 
-    int CreateAuthHandler(HttpAuthChallengeTokenizer* challenge,
+    int CreateAuthHandler(const HttpAuthChallengeTokenizer& challenge,
                           HttpAuth::Target target,
                           const GURL& origin,
                           CreateReason reason,
                           int digest_nonce_count,
                           const BoundNetLog& net_log,
                           scoped_ptr<HttpAuthHandler>* handler) override;
 
    private:
     scoped_ptr<const NonceGenerator> nonce_generator_;
   };
 
   HttpAuth::AuthorizationResult HandleAnotherChallenge(
-      HttpAuthChallengeTokenizer* challenge) override;
+      const HttpAuthChallengeTokenizer& challenge) override;
 
  protected:
-  bool Init(HttpAuthChallengeTokenizer* challenge) override;
+  int Init(const HttpAuthChallengeTokenizer& challenge) override;
 
   int GenerateAuthTokenImpl(const AuthCredentials* credentials,
-                            const HttpRequestInfo* request,
+                            const HttpRequestInfo& request,
                             const CompletionCallback& callback,
                             std::string* auth_token) override;
 
  private:
   FRIEND_TEST_ALL_PREFIXES(HttpAuthHandlerDigestTest, ParseChallenge);
   FRIEND_TEST_ALL_PREFIXES(HttpAuthHandlerDigestTest, AssembleCredentials);
   FRIEND_TEST_ALL_PREFIXES(HttpNetworkTransactionTest, DigestPreAuthNonceCount);
 
   // Possible values for the "algorithm" property.
   enum DigestAlgorithm {
@@ skipping 19 matching lines @@
   // |nonce_count| indicates how many times the server-specified nonce has
   // been used so far.
   // |nonce_generator| is used to create a client nonce, and is not owned by
   // the handler. The lifetime of the |nonce_generator| must exceed that of this
   // handler.
   HttpAuthHandlerDigest(int nonce_count, const NonceGenerator* nonce_generator);
   ~HttpAuthHandlerDigest() override;
 
   // Parse the challenge, saving the results into this instance.
   // Returns true on success.
-  bool ParseChallenge(HttpAuthChallengeTokenizer* challenge);
+  bool ParseChallenge(const HttpAuthChallengeTokenizer& challenge);
 
   // Parse an individual property. Returns true on success.
   bool ParseChallengeProperty(const std::string& name,
                               const std::string& value);
 
   // Generates a random string, to be used for client-nonce.
   static std::string GenerateNonce();
 
   // Convert enum value back to string.
   static std::string QopToString(QualityOfProtection qop);
   static std::string AlgorithmToString(DigestAlgorithm algorithm);
 
   // Extract the method and path of the request, as needed by
   // the 'A2' production. (path may be a hostname for proxy).
-  void GetRequestMethodAndPath(const HttpRequestInfo* request,
+  void GetRequestMethodAndPath(const HttpRequestInfo& request,
                                std::string* method,
                                std::string* path) const;
 
   // Build up  the 'response' production.
   std::string AssembleResponseDigest(const std::string& method,
                                      const std::string& path,
                                      const AuthCredentials& credentials,
                                      const std::string& cnonce,
                                      const std::string& nc) const;
 
@@ skipping 17 matching lines @@
   // UTF-8.
   std::string original_realm_;
 
   int nonce_count_;
   const NonceGenerator* nonce_generator_;
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_AUTH_HANDLER_DIGEST_H_