Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Unified Diff: net/http/http_auth_handler_ntlm_portable.cc

Issue 1383613002: [net/http auth] Cleanup. Method names, and constness. Base URL: https://chromium.googlesource.com/chromium/src.git@mock-auth-handler-generalization
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth_handler_ntlm.cc ('k') | net/http/http_auth_handler_ntlm_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_handler_ntlm_portable.cc
diff --git a/net/http/http_auth_handler_ntlm_portable.cc b/net/http/http_auth_handler_ntlm_portable.cc
index 54d4492a4bfd3d1564e42e046d6e36cb3e8303d4..5bc03877af32be911e437337c9b2075cb8610adf 100644
--- a/net/http/http_auth_handler_ntlm_portable.cc
+++ b/net/http/http_auth_handler_ntlm_portable.cc
@@ -711,7 +711,7 @@ int HttpAuthHandlerNTLM::GetNextToken(const void* in_token,
}
int HttpAuthHandlerNTLM::Factory::CreateAuthHandler(
- HttpAuthChallengeTokenizer* challenge,
+ const HttpAuthChallengeTokenizer& challenge,
HttpAuth::Target target,
const GURL& origin,
CreateReason reason,
@@ -725,10 +725,11 @@ int HttpAuthHandlerNTLM::Factory::CreateAuthHandler(
// NOTE: Default credentials are not supported for the portable implementation
// of NTLM.
scoped_ptr<HttpAuthHandler> tmp_handler(new HttpAuthHandlerNTLM);
- if (!tmp_handler->InitFromChallenge(challenge, target, origin, net_log))
- return ERR_INVALID_RESPONSE;
- handler->swap(tmp_handler);
- return OK;
+ int result =
+ tmp_handler->HandleInitialChallenge(challenge, target, origin, net_log);
+ if (result == OK)
+ handler->swap(tmp_handler);
+ return result;
}
} // namespace net
« no previous file with comments | « net/http/http_auth_handler_ntlm.cc ('k') | net/http/http_auth_handler_ntlm_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698