net/http/http_auth_handler_factory_unittest.cc - Issue 1383613002: [net/http auth] Cleanup. Method names, and constness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_auth_handler_factory_unittest.cc

Issue 1383613002: [net/http auth] Cleanup. Method names, and constness. Base URL: https://chromium.googlesource.com/chromium/src.git@mock-auth-handler-generalization

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_auth_handler_factory_unittest.cc

diff --git a/net/http/http_auth_handler_factory_unittest.cc b/net/http/http_auth_handler_factory_unittest.cc

index 97085b2851aaf1f6d81b1e1e1138a5a2c28d625c..6a6d282b15cc2e40f0ce038f6ca1e03c65556e67 100644

--- a/net/http/http_auth_handler_factory_unittest.cc

+++ b/net/http/http_auth_handler_factory_unittest.cc

@@ -21,7 +21,7 @@ class MockHttpAuthHandlerFactory : public HttpAuthHandlerFactory {

return_code_(return_code) {}

~MockHttpAuthHandlerFactory() override {}

- int CreateAuthHandler(HttpAuthChallengeTokenizer* challenge,

+ int CreateAuthHandler(const HttpAuthChallengeTokenizer& challenge,

HttpAuth::Target target,

const GURL& origin,

CreateReason reason,

« no previous file with comments | « net/http/http_auth_handler_factory.cc ('k') | net/http/http_auth_handler_mock.h » ('j') | no next file with comments »