Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: net/http/http_auth_handler_digest.h

Issue 1383613002: [net/http auth] Cleanup. Method names, and constness. Base URL: https://chromium.googlesource.com/chromium/src.git@mock-auth-handler-generalization
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth_handler_basic_unittest.cc ('k') | net/http/http_auth_handler_digest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_handler_digest.h
diff --git a/net/http/http_auth_handler_digest.h b/net/http/http_auth_handler_digest.h
index dbe02b4f2da0e43f8ad9fc46532adab549d24e6d..5621c2a85192d3c85545fba0f93e3e3e54d5131b 100644
--- a/net/http/http_auth_handler_digest.h
+++ b/net/http/http_auth_handler_digest.h
@@ -65,7 +65,7 @@ class NET_EXPORT_PRIVATE HttpAuthHandlerDigest : public HttpAuthHandler {
// This factory owns the passed in |nonce_generator|.
void set_nonce_generator(const NonceGenerator* nonce_generator);
- int CreateAuthHandler(HttpAuthChallengeTokenizer* challenge,
+ int CreateAuthHandler(const HttpAuthChallengeTokenizer& challenge,
HttpAuth::Target target,
const GURL& origin,
CreateReason reason,
@@ -78,13 +78,13 @@ class NET_EXPORT_PRIVATE HttpAuthHandlerDigest : public HttpAuthHandler {
};
HttpAuth::AuthorizationResult HandleAnotherChallenge(
- HttpAuthChallengeTokenizer* challenge) override;
+ const HttpAuthChallengeTokenizer& challenge) override;
protected:
- bool Init(HttpAuthChallengeTokenizer* challenge) override;
+ int Init(const HttpAuthChallengeTokenizer& challenge) override;
int GenerateAuthTokenImpl(const AuthCredentials* credentials,
- const HttpRequestInfo* request,
+ const HttpRequestInfo& request,
const CompletionCallback& callback,
std::string* auth_token) override;
@@ -124,7 +124,7 @@ class NET_EXPORT_PRIVATE HttpAuthHandlerDigest : public HttpAuthHandler {
// Parse the challenge, saving the results into this instance.
// Returns true on success.
- bool ParseChallenge(HttpAuthChallengeTokenizer* challenge);
+ bool ParseChallenge(const HttpAuthChallengeTokenizer& challenge);
// Parse an individual property. Returns true on success.
bool ParseChallengeProperty(const std::string& name,
@@ -139,7 +139,7 @@ class NET_EXPORT_PRIVATE HttpAuthHandlerDigest : public HttpAuthHandler {
// Extract the method and path of the request, as needed by
// the 'A2' production. (path may be a hostname for proxy).
- void GetRequestMethodAndPath(const HttpRequestInfo* request,
+ void GetRequestMethodAndPath(const HttpRequestInfo& request,
std::string* method,
std::string* path) const;
« no previous file with comments | « net/http/http_auth_handler_basic_unittest.cc ('k') | net/http/http_auth_handler_digest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698