Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1107)

Unified Diff: net/android/http_auth_negotiate_android_unittest.cc

Issue 1383613002: [net/http auth] Cleanup. Method names, and constness. Base URL: https://chromium.googlesource.com/chromium/src.git@mock-auth-handler-generalization
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/android/http_auth_negotiate_android.cc ('k') | net/http/http_auth.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/android/http_auth_negotiate_android_unittest.cc
diff --git a/net/android/http_auth_negotiate_android_unittest.cc b/net/android/http_auth_negotiate_android_unittest.cc
index b1e178f588d0be3c2905e868be3f3d5c5cfbb814..8b3272c32056bcb65171b06ab57ed252f9bbab58 100644
--- a/net/android/http_auth_negotiate_android_unittest.cc
+++ b/net/android/http_auth_negotiate_android_unittest.cc
@@ -42,7 +42,7 @@ TEST(HttpAuthNegotiateAndroidTest, ParseChallenge_FirstRound) {
HttpAuthChallengeTokenizer challenge(challenge_text.begin(),
challenge_text.end());
EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_ACCEPT,
- auth.ParseChallenge(&challenge));
+ auth.ParseChallenge(challenge));
}
TEST(HttpAuthNegotiateAndroidTest, ParseChallenge_UnexpectedTokenFirstRound) {
@@ -53,7 +53,7 @@ TEST(HttpAuthNegotiateAndroidTest, ParseChallenge_UnexpectedTokenFirstRound) {
HttpAuthChallengeTokenizer challenge(challenge_text.begin(),
challenge_text.end());
EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_INVALID,
- auth.ParseChallenge(&challenge));
+ auth.ParseChallenge(challenge));
}
TEST(HttpAuthNegotiateAndroidTest, ParseChallenge_TwoRounds) {
@@ -64,13 +64,13 @@ TEST(HttpAuthNegotiateAndroidTest, ParseChallenge_TwoRounds) {
HttpAuthChallengeTokenizer first_challenge(first_challenge_text.begin(),
first_challenge_text.end());
EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_ACCEPT,
- auth.ParseChallenge(&first_challenge));
+ auth.ParseChallenge(first_challenge));
std::string second_challenge_text = "Negotiate Zm9vYmFy";
HttpAuthChallengeTokenizer second_challenge(second_challenge_text.begin(),
second_challenge_text.end());
EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_ACCEPT,
- auth.ParseChallenge(&second_challenge));
+ auth.ParseChallenge(second_challenge));
}
TEST(HttpAuthNegotiateAndroidTest, ParseChallenge_MissingTokenSecondRound) {
@@ -81,13 +81,13 @@ TEST(HttpAuthNegotiateAndroidTest, ParseChallenge_MissingTokenSecondRound) {
HttpAuthChallengeTokenizer first_challenge(first_challenge_text.begin(),
first_challenge_text.end());
EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_ACCEPT,
- auth.ParseChallenge(&first_challenge));
+ auth.ParseChallenge(first_challenge));
std::string second_challenge_text = "Negotiate";
HttpAuthChallengeTokenizer second_challenge(second_challenge_text.begin(),
second_challenge_text.end());
EXPECT_EQ(HttpAuth::AUTHORIZATION_RESULT_REJECT,
- auth.ParseChallenge(&second_challenge));
+ auth.ParseChallenge(second_challenge));
}
} // namespace android
« no previous file with comments | « net/android/http_auth_negotiate_android.cc ('k') | net/http/http_auth.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698