net/http/http_auth_handler_factory.h - Issue 1383613002: [net/http auth] Cleanup. Method names, and constness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_auth_handler_factory.h

Issue 1383613002: [net/http auth] Cleanup. Method names, and constness. Base URL: https://chromium.googlesource.com/chromium/src.git@mock-auth-handler-generalization

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_auth_handler_factory.h

diff --git a/net/http/http_auth_handler_factory.h b/net/http/http_auth_handler_factory.h

index c068932fac982634d38ed7db51f648e98b74b667..88ff87a7839a75cbbb2ade78e6d7d45d109885ab 100644

--- a/net/http/http_auth_handler_factory.h

+++ b/net/http/http_auth_handler_factory.h

@@ -74,7 +74,7 @@ class NET_EXPORT HttpAuthHandlerFactory {

// NOTE: This will apply to ALL |origin| values if the filters are empty.

// |*challenge| should not be reused after a call to |CreateAuthHandler()|,

- virtual int CreateAuthHandler(HttpAuthChallengeTokenizer* challenge,

+ virtual int CreateAuthHandler(const HttpAuthChallengeTokenizer& challenge,

HttpAuth::Target target,

const GURL& origin,

CreateReason create_reason,

@@ -190,7 +190,7 @@ class NET_EXPORT HttpAuthHandlerRegistryFactory

// Create an auth handler by dispatching the CreateAuthHandler() call to the

// factory registered to handle challenge->scheme().

- int CreateAuthHandler(HttpAuthChallengeTokenizer* challenge,

+ int CreateAuthHandler(const HttpAuthChallengeTokenizer& challenge,

HttpAuth::Target target,

const GURL& origin,

CreateReason reason,

« no previous file with comments | « net/http/http_auth_handler_digest_unittest.cc ('k') | net/http/http_auth_handler_factory.cc » ('j') | no next file with comments »