[net/http auth] Cleanup. Method names, and constness.

net/http/http_auth_handler_mock.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_AUTH_HANDLER_MOCK_H_
 #define NET_HTTP_HTTP_AUTH_HANDLER_MOCK_H_
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
@@ skipping 18 matching lines @@
     Factory();
     ~Factory() override;
 
     void AddMockHandler(scoped_ptr<HttpAuthHandler> handler,
                         CreateReason reason,
                         HttpAuth::Target target);
 
     bool HaveAuthHandlers(HttpAuth::Target) const;
 
     // HttpAuthHandlerFactory:
-    int CreateAuthHandler(HttpAuthChallengeTokenizer* challenge,
+    int CreateAuthHandler(const HttpAuthChallengeTokenizer& challenge,
                           HttpAuth::Target target,
                           const GURL& origin,
                           CreateReason reason,
                           int nonce_count,
                           const BoundNetLog& net_log,
                           scoped_ptr<HttpAuthHandler>* handler) override;
 
    private:
     ScopedVector<HttpAuthHandler>
         challenge_handlers_[HttpAuth::AUTH_NUM_TARGETS];
@@ skipping 26 matching lines @@
   void set_auth_token(const std::string& auth_token) {
     auth_token_ = auth_token;
   }
 
   const GURL& request_url() const {
     return request_url_;
   }
 
   // HttpAuthHandler:
   HttpAuth::AuthorizationResult HandleAnotherChallenge(
-      HttpAuthChallengeTokenizer* challenge) override;
+      const HttpAuthChallengeTokenizer& challenge) override;
   bool NeedsIdentity() override;
   bool AllowsDefaultCredentials() override;
   bool AllowsExplicitCredentials() override;
 
  protected:
-  bool Init(HttpAuthChallengeTokenizer* challenge) override;
+  int Init(const HttpAuthChallengeTokenizer& challenge) override;
 
   int GenerateAuthTokenImpl(const AuthCredentials* credentials,
-                            const HttpRequestInfo* request,
+                            const HttpRequestInfo& request,
                             const CompletionCallback& callback,
                             std::string* auth_token) override;
 
  private:
   void OnGenerateAuthToken();
 
   CompletionCallback callback_;
   std::string expected_auth_scheme_;
   bool generate_async_ = false;
   int generate_rv_ = 0;
   std::string auth_token_;
   std::string* generate_auth_token_buffer_ = nullptr;
   bool first_round_ = true;
   bool allows_default_credentials_ = false;
   bool allows_explicit_credentials_ = true;
   bool expect_multiple_challenges_ = false;
   GURL request_url_;
   base::WeakPtrFactory<HttpAuthHandlerMock> weak_factory_;
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_AUTH_HANDLER_MOCK_H_