Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issue 1341423002: Reflow comments to use the full width. (Closed)

Created:
5 years, 3 months ago by ascull
Modified:
5 years, 3 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 25

Patch Set 2 : Fix spelling and rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2799 lines, -3042 lines) Patch
M src/IceAPFloat.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceAssembler.h View 6 chunks +21 lines, -21 lines 0 comments Download
M src/IceAssembler.cpp View 3 chunks +11 lines, -11 lines 0 comments Download
M src/IceAssemblerX86Base.h View 1 5 chunks +13 lines, -13 lines 0 comments Download
M src/IceAssemblerX86BaseImpl.h View 1 5 chunks +15 lines, -16 lines 0 comments Download
M src/IceBrowserCompileServer.h View 4 chunks +16 lines, -18 lines 0 comments Download
M src/IceBrowserCompileServer.cpp View 3 chunks +10 lines, -11 lines 0 comments Download
M src/IceCfg.h View 1 7 chunks +25 lines, -28 lines 0 comments Download
M src/IceCfg.cpp View 1 19 chunks +63 lines, -68 lines 0 comments Download
M src/IceCfgNode.h View 1 3 chunks +9 lines, -11 lines 0 comments Download
M src/IceCfgNode.cpp View 1 44 chunks +214 lines, -238 lines 0 comments Download
M src/IceClFlags.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceClFlags.cpp View 1 5 chunks +18 lines, -19 lines 0 comments Download
M src/IceCompileServer.h View 2 chunks +10 lines, -10 lines 0 comments Download
M src/IceCompileServer.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M src/IceCompiler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceCompiler.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/IceConditionCodesARM32.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceConverter.h View 2 chunks +4 lines, -5 lines 0 comments Download
M src/IceConverter.cpp View 1 9 chunks +26 lines, -31 lines 0 comments Download
M src/IceDefs.h View 7 chunks +26 lines, -27 lines 0 comments Download
M src/IceELFObjectWriter.h View 6 chunks +38 lines, -38 lines 0 comments Download
M src/IceELFObjectWriter.cpp View 1 8 chunks +26 lines, -28 lines 0 comments Download
M src/IceELFSection.h View 13 chunks +46 lines, -48 lines 0 comments Download
M src/IceELFSection.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/IceELFStreamer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceFixups.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceGlobalContext.h View 10 chunks +42 lines, -43 lines 0 comments Download
M src/IceGlobalContext.cpp View 9 chunks +37 lines, -40 lines 0 comments Download
M src/IceGlobalInits.h View 1 5 chunks +14 lines, -16 lines 0 comments Download
M src/IceGlobalInits.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M src/IceInst.h View 29 chunks +100 lines, -109 lines 0 comments Download
M src/IceInst.cpp View 12 chunks +48 lines, -50 lines 0 comments Download
M src/IceInst.def View 1 chunk +1 line, -2 lines 0 comments Download
M src/IceInstARM32.h View 1 21 chunks +64 lines, -65 lines 0 comments Download
M src/IceInstARM32.cpp View 1 6 chunks +20 lines, -22 lines 0 comments Download
M src/IceInstARM32.def View 6 chunks +25 lines, -25 lines 0 comments Download
M src/IceInstMIPS32.h View 2 chunks +10 lines, -10 lines 0 comments Download
M src/IceInstMIPS32.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceInstX8632.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/IceInstX8664.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/IceInstX86Base.h View 1 24 chunks +85 lines, -96 lines 0 comments Download
M src/IceInstX86BaseImpl.h View 28 chunks +95 lines, -109 lines 0 comments Download
M src/IceIntrinsics.h View 1 6 chunks +21 lines, -22 lines 0 comments Download
M src/IceIntrinsics.cpp View 1 3 chunks +6 lines, -6 lines 0 comments Download
M src/IceLiveness.h View 3 chunks +19 lines, -22 lines 0 comments Download
M src/IceLiveness.cpp View 5 chunks +12 lines, -14 lines 0 comments Download
M src/IceLoopAnalyzer.h View 1 2 chunks +7 lines, -3 lines 0 comments Download
M src/IceLoopAnalyzer.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/IceOperand.h View 16 chunks +74 lines, -81 lines 0 comments Download
M src/IceOperand.cpp View 7 chunks +27 lines, -31 lines 0 comments Download
M src/IcePhiLoweringImpl.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/IceRNG.h View 2 chunks +6 lines, -6 lines 0 comments Download
M src/IceRNG.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/IceRegAlloc.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/IceRegAlloc.cpp View 8 chunks +19 lines, -18 lines 0 comments Download
M src/IceRegistersARM32.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/IceRegistersX8632.h View 4 chunks +8 lines, -8 lines 0 comments Download
M src/IceRegistersX8664.h View 4 chunks +8 lines, -8 lines 0 comments Download
M src/IceSwitchLowering.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceSwitchLowering.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceTLS.h View 3 chunks +19 lines, -21 lines 0 comments Download
M src/IceTargetLowering.h View 1 13 chunks +73 lines, -80 lines 0 comments Download
M src/IceTargetLowering.cpp View 12 chunks +56 lines, -60 lines 0 comments Download
M src/IceTargetLoweringARM32.h View 1 11 chunks +29 lines, -32 lines 0 comments Download
M src/IceTargetLoweringARM32.cpp View 1 70 chunks +281 lines, -299 lines 0 comments Download
M src/IceTargetLoweringMIPS32.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceTargetLoweringMIPS32.cpp View 10 chunks +37 lines, -42 lines 0 comments Download
M src/IceTargetLoweringX8632.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/IceTargetLoweringX8632.cpp View 24 chunks +108 lines, -123 lines 0 comments Download
M src/IceTargetLoweringX8632Traits.h View 8 chunks +22 lines, -22 lines 0 comments Download
M src/IceTargetLoweringX8664.cpp View 24 chunks +103 lines, -115 lines 0 comments Download
M src/IceTargetLoweringX8664Traits.h View 8 chunks +22 lines, -22 lines 0 comments Download
M src/IceTargetLoweringX86Base.h View 1 9 chunks +28 lines, -30 lines 0 comments Download
M src/IceTargetLoweringX86BaseImpl.h View 1 85 chunks +277 lines, -294 lines 0 comments Download
M src/IceThreading.h View 6 chunks +50 lines, -59 lines 0 comments Download
M src/IceTimerTree.h View 2 chunks +14 lines, -15 lines 0 comments Download
M src/IceTimerTree.cpp View 12 chunks +34 lines, -36 lines 0 comments Download
M src/IceTimerTree.def View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceTranslator.h View 3 chunks +10 lines, -10 lines 0 comments Download
M src/IceTranslator.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceTypeConverter.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/IceTypes.h View 4 chunks +8 lines, -9 lines 0 comments Download
M src/IceTypes.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/IceTypes.def View 2 chunks +5 lines, -6 lines 0 comments Download
M src/IceUtils.h View 2 chunks +6 lines, -7 lines 0 comments Download
M src/PNaClTranslator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/PNaClTranslator.cpp View 1 56 chunks +178 lines, -203 lines 0 comments Download
M src/README.SIMD.rst View 2 chunks +25 lines, -28 lines 0 comments Download
M src/main.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ascull
I thought I'd try and improve build times by removing 300 lines. It also means ...
5 years, 3 months ago (2015-09-15 22:49:58 UTC) #2
Jim Stichnoth
LGTM, thanks! https://codereview.chromium.org/1341423002/diff/1/src/IceAssemblerX86Base.h File src/IceAssemblerX86Base.h (right): https://codereview.chromium.org/1341423002/diff/1/src/IceAssemblerX86Base.h#newcode963 src/IceAssemblerX86Base.h:963: // instrutions.) If Addr is not nullptr, ...
5 years, 3 months ago (2015-09-16 00:01:29 UTC) #3
ascull
https://codereview.chromium.org/1341423002/diff/1/src/IceAssemblerX86Base.h File src/IceAssemblerX86Base.h (right): https://codereview.chromium.org/1341423002/diff/1/src/IceAssemblerX86Base.h#newcode963 src/IceAssemblerX86Base.h:963: // instrutions.) If Addr is not nullptr, then Rm ...
5 years, 3 months ago (2015-09-16 18:30:10 UTC) #4
ascull
5 years, 3 months ago (2015-09-16 18:30:12 UTC) #5
ascull
5 years, 3 months ago (2015-09-16 18:30:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
57e126899b20c65ff3ea23a3b7d7a67ab30b99dc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698