Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: src/IceBrowserCompileServer.h

Issue 1341423002: Reflow comments to use the full width. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix spelling and rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceAssemblerX86BaseImpl.h ('k') | src/IceBrowserCompileServer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceBrowserCompileServer.h
diff --git a/src/IceBrowserCompileServer.h b/src/IceBrowserCompileServer.h
index e76b820679f00fb64a6c48fa0c6f869c9069efbc..f23ab17b425bda8005d08948cffdb9a4ed5de2d7 100644
--- a/src/IceBrowserCompileServer.h
+++ b/src/IceBrowserCompileServer.h
@@ -31,12 +31,11 @@ class raw_fd_ostream;
namespace Ice {
-/// The browser variant of the compile server.
-/// Compared to the commandline version, this version gets compile
-/// requests over IPC. Each compile request will have a slimmed down
-/// version of argc, argv while other flags are set to defaults that
-/// make sense in the browser case. The output file is specified via
-/// a posix FD, and input bytes are pushed to the server.
+/// The browser variant of the compile server. Compared to the commandline
+/// version, this version gets compile requests over IPC. Each compile request
+/// will have a slimmed down version of argc, argv while other flags are set to
+/// defaults that make sense in the browser case. The output file is specified
+/// via a posix FD, and input bytes are pushed to the server.
class BrowserCompileServer : public CompileServer {
BrowserCompileServer() = delete;
BrowserCompileServer(const BrowserCompileServer &) = delete;
@@ -56,12 +55,12 @@ public:
/// Parse and set up the flags for compile jobs.
void getParsedFlags(uint32_t NumThreads, int argc, char **argv);
- /// Creates the streams + context and starts the compile thread,
- /// handing off the streams + context.
+ /// Creates the streams + context and starts the compile thread, handing off
+ /// the streams + context.
void startCompileThread(int OutFD);
- /// Call to push more bytes to the current input stream.
- /// Returns false on success and true on error.
+ /// Call to push more bytes to the current input stream. Returns false on
+ /// success and true on error.
bool pushInputBytes(const void *Data, size_t NumBytes);
/// Notify the input stream of EOF.
@@ -72,9 +71,8 @@ public:
CompileThread.join();
if (Ctx->getErrorStatus()->value())
LastError.assign(Ctx->getErrorStatus()->value());
- // Reset some state. The InputStream is deleted by the compiler
- // so only reset this to nullptr. Free and flush the rest
- // of the streams.
+ // Reset some state. The InputStream is deleted by the compiler so only
+ // reset this to nullptr. Free and flush the rest of the streams.
InputStream = nullptr;
EmitStream.reset(nullptr);
ELFStream.reset(nullptr);
@@ -95,12 +93,12 @@ private:
std::string Buffer;
llvm::raw_string_ostream StrBuf;
};
- /// This currently only handles a single compile request, hence one copy
- /// of the state.
+ /// This currently only handles a single compile request, hence one copy of
+ /// the state.
std::unique_ptr<GlobalContext> Ctx;
- /// A borrowed reference to the current InputStream. The compiler owns
- /// the actual reference so the server must be careful not to access
- /// after the compiler is done.
+ /// A borrowed reference to the current InputStream. The compiler owns the
+ /// actual reference so the server must be careful not to access after the
+ /// compiler is done.
llvm::QueueStreamer *InputStream = nullptr;
std::unique_ptr<Ostream> LogStream;
std::unique_ptr<llvm::raw_fd_ostream> EmitStream;
« no previous file with comments | « src/IceAssemblerX86BaseImpl.h ('k') | src/IceBrowserCompileServer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698