Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1242023005: Remove legacy StartsWithASCII function. (Closed)

Created:
5 years, 5 months ago by brettw
Modified:
5 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, asanka, sadrul, yusukes+watch_chromium.org, zea+watch_chromium.org, tzik, posciak+watch_chromium.org, shuchen+watch_chromium.org, vabr+watchlist_chromium.org, browser-components-watch_chromium.org, yzshen+watch_chromium.org, avayvod+watch_chromium.org, jdduke+watch_chromium.org, noyau+watch_chromium.org, dmazzoni+watch_chromium.org, tracing+reviews_chromium.org, markusheintz_, stevenjb+watch_chromium.org, kinuko+watch, mlamouri+watch-media_chromium.org, miu+watch_chromium.org, jsbell+serviceworker_chromium.org, cbentzel+watch_chromium.org, Aaron Boodman, aboxhall+watch_chromium.org, ben+mojo_chromium.org, sdefresne+watch_chromium.org, viettrungluu+watch_chromium.org, jam, raymes+watch_chromium.org, abarth-chromium, nona+watch_chromium.org, je_julie, darin-cc_chromium.org, kalyank, tdresser+watch_chromium.org, erikwright+watch_chromium.org, android-webview-reviews_chromium.org, mlamouri+watch-content_chromium.org, chromoting-reviews_chromium.org, derat+watch_chromium.org, extensions-reviews_chromium.org, qsr+mojo_chromium.org, penghuang+watch_chromium.org, yuzo+watch_chromium.org, rickyz+watch_chromium.org, feature-media-reviews_chromium.org, nhiroki, oshima+watch_chromium.org, horo+watch_chromium.org, piman+watch_chromium.org, gcasto+watchlist_chromium.org, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org, michaeln, plundblad+watch_chromium.org, hashimoto+watch_chromium.org, wfh+watch_chromium.org, serviceworker-reviews, nektar+watch_chromium.org, mcasas+watch_chromium.org, chromium-apps-reviews_chromium.org, ozone-reviews_chromium.org, benjhayden+dwatch_chromium.org, kinuko+serviceworker, jln+watch_chromium.org, dtseng+watch_chromium.org, tfarina, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, darin (slow to review), James Su, wjia+watch_chromium.org, kinuko+fileapi, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove legacy StartsWithASCII function. This replaces it with base::StartsWith and the appropriate case flag. Since the existing version only ever did case-insensitive tests in ASCII, there should be no behavior change. BUG=506255 TBR=jam Committed: https://crrev.com/955093110ad64d5ec6f5426991efaa4a680b5d6f Cr-Commit-Position: refs/heads/master@{#339175}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : y #

Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -218 lines) Patch
M android_webview/native/android_protocol_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/native/aw_media_url_interceptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/lock_state_controller.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M base/files/file_path.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/string_util.h View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/interstitials/interstitial_ui.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/dbus/bluetooth_gatt_characteristic_service_provider.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chromeos/dbus/bluetooth_gatt_descriptor_service_provider.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_gatt_characteristic_service_provider.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_gatt_descriptor_service_provider.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chromeos/dbus/fake_shill_service_client.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chromeos/dbus/session_manager_client.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chromeos/disks/disk_mount_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chromeos/settings/cros_settings_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/system/version_loader.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/content/renderer/form_autofill_util.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_download_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/autofill/core/browser/form_structure.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/cloud_devices/common/cloud_devices_urls.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/content_settings/core/common/content_settings_pattern_parser.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/cronet/android/test/native_test_server.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/favicon/core/favicon_driver_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/gcm_driver/registration_info.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/google/core/browser/google_url_tracker.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/google/core/browser/google_util.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/html_viewer/web_mime_registry_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/html_viewer/web_url_loader_impl.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M components/invalidation/impl/gcm_network_channel_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/mime_util/mime_util.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M components/nacl/renderer/ppb_nacl_private_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/password_manager/core/browser/affiliation_utils.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/password_manager/core/browser/password_form_manager.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/proximity_auth/cryptauth/fake_secure_message_delegate.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/suggestions/suggestions_service.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/translate/core/browser/translate_prefs.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/translate/core/language_detection/language_detection_util.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M components/url_fixer/url_fixer.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M components/user_manager/user_image/default_user_images.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/variations/net/variations_http_header_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/dump_accessibility_browsertest_base.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M content/browser/download/download_stats.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M content/browser/fileapi/fileapi_message_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gamepad/gamepad_platform_data_fetcher_linux.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/media/capture/web_contents_capture_util.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_utils.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/session_history_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/tracing/tracing_ui.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/webui/shared_resources_data_source.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/child/blink_platform_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/multipart_response_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/plugin_host.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/child/simple_webmimeregistry_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/appcache_interfaces.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/test/browser_test_utils.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/test/test_launcher.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/renderer/savable_resources.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/api/cast_channel/logger.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/api/web_request/web_request_api.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_apitest.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/warning_set.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/csp_validator.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M extensions/common/extension.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M extensions/common/permissions/permissions_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/common/shell_content_client_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M google_apis/drive/test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/fake_gaia.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M google_apis/gcm/engine/gcm_store_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/config/gpu_control_list.cc View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/config/gpu_info_collector_linux.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M gpu/config/gpu_test_expectations_parser.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/app/safe_mode_util_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ios/chrome/browser/experimental_flags.mm View 1 chunk +2 lines, -1 line 0 comments Download
M ios/net/clients/crn_forwarding_network_client_factory_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M media/base/android/media_codec_bridge.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M media/base/android/media_player_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/key_systems.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M media/base/mime_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/renderers/video_renderer_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/video/capture/win/video_capture_device_factory_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/runner/shell_apptest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M pdf/document_loader.cc View 4 chunks +9 lines, -5 lines 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/protocol/me2me_host_authenticator_factory.cc View 1 chunk +2 lines, -1 line 0 comments Download
M rlz/lib/rlz_lib.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M rlz/win/lib/machine_deal.cc View 1 chunk +2 lines, -1 line 0 comments Download
M sandbox/linux/services/yama_unittests.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M storage/browser/blob/blob_url_request_job_factory.cc View 1 chunk +2 lines, -1 line 0 comments Download
M storage/browser/fileapi/obfuscated_file_util.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M storage/browser/fileapi/sandbox_directory_database.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M storage/browser/fileapi/sandbox_origin_database.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/zlib/google/zip_reader.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tools/gn/filesystem_utils.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tools/gn/header_checker.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tools/gn/input_conversion.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tools/gn/target.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/base/ime/chromeos/component_extension_ime_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/base/ime/chromeos/extension_ime_util.cc View 2 chunks +21 lines, -18 lines 0 comments Download
M ui/base/l10n/l10n_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/x/x11_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/devices/device_util_linux.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/events/ozone/device/udev/device_manager_udev.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_version_info.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 22 (10 generated)
brettw
5 years, 5 months ago (2015-07-16 17:58:17 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242023005/1
5 years, 5 months ago (2015-07-16 17:59:37 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/79426)
5 years, 5 months ago (2015-07-16 18:12:47 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242023005/20001
5 years, 5 months ago (2015-07-16 19:10:51 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/79470)
5 years, 5 months ago (2015-07-16 19:22:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242023005/20001
5 years, 5 months ago (2015-07-16 19:43:45 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/79486)
5 years, 5 months ago (2015-07-16 19:56:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242023005/30001
5 years, 5 months ago (2015-07-16 20:09:30 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_arm_compile on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compile/builds/22121)
5 years, 5 months ago (2015-07-16 22:47:00 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242023005/30001
5 years, 5 months ago (2015-07-16 23:12:08 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:30001)
5 years, 5 months ago (2015-07-16 23:57:48 UTC) #21
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 23:59:06 UTC) #22
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/955093110ad64d5ec6f5426991efaa4a680b5d6f
Cr-Commit-Position: refs/heads/master@{#339175}

Powered by Google App Engine
This is Rietveld 408576698