Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1820)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/shell/common/shell_content_client_unittest.cc

Issue 1242023005: Remove legacy StartsWithASCII function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: y Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/permissions/permissions_info.cc ('k') | google_apis/drive/test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/shell/common/shell_content_client_unittest.cc
diff --git a/extensions/shell/common/shell_content_client_unittest.cc b/extensions/shell/common/shell_content_client_unittest.cc
index eb9694dabe6ebac123df64715a2e3baa654612e9..ba1540b68c20b8a613d9cdbfe4efbb5ff497c23d 100644
--- a/extensions/shell/common/shell_content_client_unittest.cc
+++ b/extensions/shell/common/shell_content_client_unittest.cc
@@ -20,7 +20,8 @@ TEST_F(ShellContentClientTest, UserAgentFormat) {
std::string user_agent = client.GetUserAgent();
// Must start with the usual Mozilla-compatibility string.
- EXPECT_TRUE(base::StartsWithASCII(user_agent, "Mozilla/5.0", false))
+ EXPECT_TRUE(base::StartsWith(user_agent, "Mozilla/5.0",
+ base::CompareCase::INSENSITIVE_ASCII))
<< user_agent;
// Must contain a substring like "Chrome/1.2.3.4".
« no previous file with comments | « extensions/common/permissions/permissions_info.cc ('k') | google_apis/drive/test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698