components/translate/core/browser/translate_prefs.cc - Issue 1242023005: Remove legacy StartsWithASCII function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/core/browser/translate_prefs.cc

Issue 1242023005: Remove legacy StartsWithASCII function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: y Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/translate/core/browser/translate_prefs.cc

diff --git a/components/translate/core/browser/translate_prefs.cc b/components/translate/core/browser/translate_prefs.cc

index 24547005fd11f9c947244da40725dbc8de87895a..571241af3c9178bc03d1172290544df6826a3144 100644

--- a/components/translate/core/browser/translate_prefs.cc

+++ b/components/translate/core/browser/translate_prefs.cc

@@ -511,7 +511,8 @@ void TranslatePrefs::CreateBlockedLanguages(

TranslateDownloadManager::GetInstance()->application_locale();

std::string ui_lang = TranslateDownloadManager::GetLanguageCode(app_locale);

bool is_ui_english =

- ui_lang == "en" || base::StartsWithASCII(ui_lang, "en-", false);

+ ui_lang == "en" ||

+ base::StartsWith(ui_lang, "en-", base::CompareCase::INSENSITIVE_ASCII);

for (std::vector<std::string>::const_iterator it = accept_languages.begin();

it != accept_languages.end(); ++it) {