tools/gn/target.cc - Issue 1242023005: Remove legacy StartsWithASCII function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/target.cc

Issue 1242023005: Remove legacy StartsWithASCII function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: y Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/target.cc

diff --git a/tools/gn/target.cc b/tools/gn/target.cc

index a7a3d07d2063e1b49aca0505d4a419c911889fb9..71488cb8a3932ba8a82ad7408dc8fc4ad5aab340 100644

--- a/tools/gn/target.cc

+++ b/tools/gn/target.cc

@@ -219,7 +219,8 @@ std::string Target::GetComputedOutputName(bool include_prefix) const {

const Tool* tool = toolchain_->GetToolForTargetFinalOutput(this);

if (tool) {

// Only add the prefix if the name doesn't already have it.

- if (!base::StartsWithASCII(name, tool->output_prefix(), true))

+ if (!base::StartsWith(name, tool->output_prefix(),

+ base::CompareCase::SENSITIVE))

result = tool->output_prefix();

}