components/nacl/renderer/ppb_nacl_private_impl.cc - Issue 1242023005: Remove legacy StartsWithASCII function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/renderer/ppb_nacl_private_impl.cc

Issue 1242023005: Remove legacy StartsWithASCII function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: y Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/renderer/ppb_nacl_private_impl.cc

diff --git a/components/nacl/renderer/ppb_nacl_private_impl.cc b/components/nacl/renderer/ppb_nacl_private_impl.cc

index e40bdd31f89366346e1d817d40496cb421b5f4e3..3d67fc701704b4437d67d557c5a8162e7b84c081 100644

--- a/components/nacl/renderer/ppb_nacl_private_impl.cc

+++ b/components/nacl/renderer/ppb_nacl_private_impl.cc

@@ -610,7 +610,8 @@ std::string PnaclComponentURLToFilename(const std::string& url) {

// generated from ManifestResolveKey or PnaclResources::ReadResourceInfo.

// So, it's safe to just use string parsing operations here instead of

// URL-parsing ones.

- DCHECK(base::StartsWithASCII(url, kPNaClTranslatorBaseUrl, true));

+ DCHECK(base::StartsWith(url, kPNaClTranslatorBaseUrl,

+ base::CompareCase::SENSITIVE));

std::string r = url.substr(std::string(kPNaClTranslatorBaseUrl).length());

// Use white-listed-chars.