extensions/browser/api/web_request/web_request_api.cc - Issue 1242023005: Remove legacy StartsWithASCII function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/web_request/web_request_api.cc

Issue 1242023005: Remove legacy StartsWithASCII function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: y Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/web_request/web_request_api.cc

diff --git a/extensions/browser/api/web_request/web_request_api.cc b/extensions/browser/api/web_request/web_request_api.cc

index 1290440886d69568343617a133cb82e086a97464..88212320ef6a97acc281b35745777b37af4836ee 100644

--- a/extensions/browser/api/web_request/web_request_api.cc

+++ b/extensions/browser/api/web_request/web_request_api.cc

@@ -137,8 +137,9 @@ int GetFrameId(bool is_main_frame, int frame_id) {

bool IsWebRequestEvent(const std::string& event_name) {

std::string web_request_event_name(event_name);

- if (base::StartsWithASCII(web_request_event_name,

- webview::kWebViewEventPrefix, true)) {

+ if (base::StartsWith(web_request_event_name,

+ webview::kWebViewEventPrefix,

+ base::CompareCase::SENSITIVE)) {

web_request_event_name.replace(

0, strlen(webview::kWebViewEventPrefix), kWebRequestEventPrefix);

}