tools/gn/header_checker.cc - Issue 1242023005: Remove legacy StartsWithASCII function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/header_checker.cc

Issue 1242023005: Remove legacy StartsWithASCII function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: y Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/header_checker.cc

diff --git a/tools/gn/header_checker.cc b/tools/gn/header_checker.cc

index 1141e6efd6ac73eca9e90383bc53eb38229b12d0..b15b4fa16b2b88aaf91d57426adf8a225c6f9a0d 100644

--- a/tools/gn/header_checker.cc

+++ b/tools/gn/header_checker.cc

@@ -37,7 +37,8 @@ struct PublicGeneratedPair {

SourceFile RemoveRootGenDirFromFile(const Target* target,

const SourceFile& file) {

const SourceDir& gen = target->settings()->toolchain_gen_dir();

- if (!gen.is_null() && base::StartsWithASCII(file.value(), gen.value(), true))

+ if (!gen.is_null() && base::StartsWith(file.value(), gen.value(),

+ base::CompareCase::SENSITIVE))

return SourceFile("//" + file.value().substr(gen.value().size()));

return file;

}

« no previous file with comments | « tools/gn/filesystem_utils.cc ('k') | tools/gn/input_conversion.cc » ('j') | no next file with comments »