components/html_viewer/web_mime_registry_impl.cc - Issue 1242023005: Remove legacy StartsWithASCII function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/html_viewer/web_mime_registry_impl.cc

Issue 1242023005: Remove legacy StartsWithASCII function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: y Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/html_viewer/web_mime_registry_impl.cc

diff --git a/components/html_viewer/web_mime_registry_impl.cc b/components/html_viewer/web_mime_registry_impl.cc

index a050693a098397926ba99b7309f68a8f34851546..caed08920b74a5456852d0d32b5905d5c014577f 100644

--- a/components/html_viewer/web_mime_registry_impl.cc

+++ b/components/html_viewer/web_mime_registry_impl.cc

@@ -44,7 +44,8 @@ WebMimeRegistryImpl::supportsImagePrefixedMIMEType(

const blink::WebString& mime_type) {

std::string ascii_mime_type = ToASCIIOrEmpty(mime_type);

return (mime_util::IsSupportedImageMimeType(ascii_mime_type) ||

- (base::StartsWithASCII(ascii_mime_type, "image/", true) &&

+ (base::StartsWith(ascii_mime_type, "image/",

+ base::CompareCase::SENSITIVE) &&

mime_util::IsSupportedNonImageMimeType(ascii_mime_type)))

? WebMimeRegistry::IsSupported

: WebMimeRegistry::IsNotSupported;