components/autofill/content/renderer/form_autofill_util.cc - Issue 1242023005: Remove legacy StartsWithASCII function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/form_autofill_util.cc

Issue 1242023005: Remove legacy StartsWithASCII function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: y Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/content/renderer/form_autofill_util.cc

diff --git a/components/autofill/content/renderer/form_autofill_util.cc b/components/autofill/content/renderer/form_autofill_util.cc

index b2259ed4f86cb523451238e636bb5ccbdcfc0428..b6c54ac0f50ecc8e280d6c45d4e61f7671e4008c 100644

--- a/components/autofill/content/renderer/form_autofill_util.cc

+++ b/components/autofill/content/renderer/form_autofill_util.cc

@@ -1312,7 +1312,8 @@ bool UnownedFormElementsAndFieldSetsToFormData(

std::string lang;

if (!html_element.isNull())

lang = html_element.getAttribute("lang").utf8();

- if ((lang.empty() || base::StartsWithASCII(lang, "en", false)) &&

+ if ((lang.empty() ||

+ base::StartsWith(lang, "en", base::CompareCase::INSENSITIVE_ASCII)) &&

!MatchesPattern(document.title(),

base::UTF8ToUTF16("payment|checkout|address|delivery|shipping"))) {

return false;